OCPBUGS-45295: Make plugins name array items unique

Author: jhadvig

openapi/generated_openapi/zz_generated.openapi.go

@@ -27015,7 +27015,8 @@
           "items": {
             "type": "string",
             "default": ""
-          }
+          },
+          "x-kubernetes-list-type": "atomic"
         },
         "providers": {
           "description": "providers contains configuration for using specific service providers.",

openapi/openapi.json

@@ -296,3 +296,29 @@ tests:
               visibility:
                 state: Enables
       expectedError: "spec.customization.capabilities[0].visibility.state: Unsupported value: \"Enables\": supported values: \"Enabled\", \"Disabled\""
+    - name: Should be able to create a Console with multiple plugins
+      initial: |
+        apiVersion: operator.openshift.io/v1
+        kind: Console
+        spec:
+          plugins:
+          - test-plugin-1
+          - test-plugin-2
+      expected: |
+        apiVersion: operator.openshift.io/v1
+        kind: Console
+        spec:
+          logLevel: Normal
+          operatorLogLevel: Normal
+          plugins:
+          - test-plugin-1
+          - test-plugin-2
+    - name: Should throw an error for duplicate plugin name
+      initial: |
+        apiVersion: operator.openshift.io/v1
+        kind: Console
+        spec:
+          plugins:
+          - test-plugin-1
+          - test-plugin-1
+      expectedError: "spec.plugins: Invalid value: \"array\": each plugin name must be unique"

operator/v1/tests/consoles.operator.openshift.io/AAA_ungated.yaml

@@ -55,15 +55,22 @@ type ConsoleSpec struct {
 	// +optional
 	Route ConsoleConfigRoute `json:"route"`
 	// plugins defines a list of enabled console plugin names.
+	// +listType=atomic
+	// +kubebuilder:validation:MaxItems=64
+	// +kubebuilder:validation:XValidation:rule="self.all(x, self.exists_one(y, x == y))",message="each plugin name must be unique"
 	// +optional
-	Plugins []string `json:"plugins,omitempty"`
+	Plugins []PluginName `json:"plugins,omitempty"`
 	// ingress allows to configure the alternative ingress for the console.
 	// This field is intended for clusters without ingress capability,
 	// where access to routes is not possible.
 	// +optional
 	Ingress Ingress `json:"ingress"`
 }
 
+// +kubebuilder:validation:MaxLength=128
+// +kubebuilder:validation:Pattern=^[a-zA-Z0-9-]+$
+type PluginName string
+
 // ConsoleConfigRoute holds information on external route access to console.
 // DEPRECATED
 type ConsoleConfigRoute struct {

operator/v1/types_console.go

@@ -779,8 +779,15 @@ spec:
               plugins:
                 description: plugins defines a list of enabled console plugin names.
                 items:
+                  maxLength: 128
+                  pattern: ^[a-zA-Z0-9-]+$
                   type: string
+                maxItems: 64
                 type: array
+                x-kubernetes-list-type: atomic
+                x-kubernetes-validations:
+                - message: each plugin name must be unique
+                  rule: self.all(x, self.exists_one(y, x == y))
               providers:
                 description: providers contains configuration for using specific service
                   providers.

operator/v1/zz_generated.crd-manifests/0000_50_console_01_consoles.crd.yaml

@@ -780,8 +780,15 @@ spec:
               plugins:
                 description: plugins defines a list of enabled console plugin names.
                 items:
+                  maxLength: 128
+                  pattern: ^[a-zA-Z0-9-]+$
                   type: string
+                maxItems: 64
                 type: array
+                x-kubernetes-list-type: atomic
+                x-kubernetes-validations:
+                - message: each plugin name must be unique
+                  rule: self.all(x, self.exists_one(y, x == y))
               providers:
                 description: providers contains configuration for using specific service
                   providers.