Skip to content

[core] library: export_notifications: adjust the post-processing status #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kpouget merged 1 commit into from
Sep 15, 2026
Merged

[core] library: export_notifications: adjust the post-processing status #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/caliper/orchestration/notification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def postprocess_get_file_link(file_path: Path | str, text: str = None) -> str:

return get_file_link(base_directory / file_path, text)

lines.append(f"**Post-processing Status** {status_emoji} `{base_directory}`")
lines.append(f"{status_emoji} **Post-processing Status** `{base_directory}`")

# Convert steps from list[dict] format to sorted list of (step_name, step_data) tuples
step_tuples = []
Expand Down
8 changes: 4 additions & 4 deletions projects/caliper/tests/test_notification_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def mock_get_file_link(file_path, text: str = None):
print(f"Generated notification text:\n{notification_text}\n")

# Verify overall structure
assert "**Post-processing Status** ✅" in notification_text
assert "✅ **Post-processing Status**" in notification_text
assert (
"- ✅ [**parse**](https://example.com/artifacts/logs/001_parse.log): `success`"
in notification_text
Expand Down Expand Up @@ -148,7 +148,7 @@ def mock_get_file_link(file_path, text: str = None):
notification_text = format_postprocess_status_notification(status, mock_get_file_link)

# Verify overall failure status
assert "**Post-processing Status** ❌" in notification_text
assert "❌ **Post-processing Status**" in notification_text

# Verify parse success
assert "- ✅ **parse**: `success`" in notification_text
Expand Down Expand Up @@ -189,7 +189,7 @@ def test_notification_formatting_failure():
notification_text = format_postprocess_status_notification(status)

# Verify overall failure status
assert "**Post-processing Status** ❌" in notification_text
assert "❌ **Post-processing Status**" in notification_text

# Verify failed step
assert "- ❌ **parse**: `failed`" in notification_text
Expand Down Expand Up @@ -219,7 +219,7 @@ def test_notification_without_file_links():
notification_text = format_postprocess_status_notification(status)

# Verify basic formatting without links
assert "**Post-processing Status** ✅" in notification_text
assert "✅ **Post-processing Status**" in notification_text
assert "- ✅ **parse**: `success`" in notification_text
# Should not contain any links
assert "https://" not in notification_text
Expand Down
4 changes: 1 addition & 3 deletions projects/core/library/export_notifications.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1661,9 +1661,7 @@ def _format_caliper_metadata_info_for_step(get_file_link: Any, step_dir: Path) -
else:
completion_emoji = "❓"

path_info = (
f"* {completion_emoji} **Test directory**: {metadata_file_link}{completion_emoji}"
)
path_info = f"* {completion_emoji} **Test directory**: {metadata_file_link}"
metadata_lines.append(path_info)

# Add completion message as a separate line
Expand Down
Loading