Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openshift-pipelines/pipelines-as-code
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: openshift-pipelines/pipelines-as-code
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release-v0.35.x
Choose a head ref
  • 20 commits
  • 54 files changed
  • 6 contributors

Commits on May 26, 2025

  1. Release yaml generated from d674217 for release v0.35.0

    Pipelines as Code CI Robot committed May 26, 2025
    Configuration menu
    Copy the full SHA
    57300ff View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2025

  1. DNM: downgrade go version to 1.23.6

    downgraded go version to 1.23.6 and downgraded
    cert-manager dependency version as well.
    
    Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
    zakisk committed Jun 4, 2025
    Configuration menu
    Copy the full SHA
    0b6cda8 View commit details
    Browse the repository at this point in the history
  2. Release yaml generated from 0b6cda8 for release v0.35.1

    Pipelines as Code CI Robot committed Jun 4, 2025
    Configuration menu
    Copy the full SHA
    ba5f90b View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2025

  1. chore: Update controller finalizer name to include explicit part

    *   The finalizer name used by the controller was updated.
    *   A new constant `FinalizerName` was introduced for the explicit part of the
    name.
    *   The finalizer name was updated to combine the group name and the new
    constant.
    *   This change aligns the finalizer naming with common Kubernetes conventions.
    
    Fixes #1763
    
    Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
    Co-authored-by: zakisk <zashaikh@redhat.com>
    2 people authored and savitaashture committed Jul 4, 2025
    Configuration menu
    Copy the full SHA
    6fcedc6 View commit details
    Browse the repository at this point in the history
  2. fix(gitlab): trigger PipelineRun only on label change

    Before this patch pipeline was triggered on any merge request update,
    regardless of what changed such as title, description or assigne changes
    
    With the current change, pipeline will be triggered only when labels
    are added or removed
    
    Signed-off-by: PuneetPunamiya <ppunamiy@redhat.com>
    PuneetPunamiya authored and savitaashture committed Jul 4, 2025
    Configuration menu
    Copy the full SHA
    86da7d4 View commit details
    Browse the repository at this point in the history
  3. fix: Split error message of yaml validation on push

    When a PipelineRun template in the .tekton/ directory
    contains a YAML syntax error, the error message was
    prefixed with a confusing "cannot locate templates
    in .tekton directory" message.
    
    This change ensures the error accurately reflects that
    a file was found but failed to parse, avoiding
    confusion between empty .tekton directory
    and a malformed one.
    
    Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
    zakisk authored and savitaashture committed Jul 4, 2025
    Configuration menu
    Copy the full SHA
    ad8fea1 View commit details
    Browse the repository at this point in the history
  4. fix: add timeouts to HTTP server

    - Added ReadHeaderTimeout, ReadTimeout, and IdleTimeout to HTTP server
      for improved security and reliability
    chmouel authored and savitaashture committed Jul 4, 2025
    Configuration menu
    Copy the full SHA
    f780e96 View commit details
    Browse the repository at this point in the history
  5. fix: avoid reporting errors for non-Tekton res

    The handling of YAML validation errors was refactored to be more
    intelligent and less noisy. It now only reports errors for resources
    that are identified as Tekton resources or are fundamentally invalid YAML.
    
    - Refactored validation errors from a simple map to a structured type
      that includes the resource name, schema, and error object.
    - Updated YAML parsing to extract the resource's `apiVersion` (schema)
      even when the document fails to decode fully as a Tekton object.
    - Implemented filtering to report validation errors only for resources
      with a `tekton.dev` API group or for generic YAML syntax errors.
    - This prevents creating error comments on pull requests for other
      valid, non-Tekton YAML files located in the `.tekton` directory.
    
    Jira: https://issues.redhat.com/browse/SRVKP-7906
    
    Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
    chmouel authored and savitaashture committed Jul 4, 2025
    Configuration menu
    Copy the full SHA
    bea1de2 View commit details
    Browse the repository at this point in the history
  6. fix: handle response body close errors

    - Added error handling for closing HTTP response body to improve robustness
    - Changed list function to return result of writer flush for better
      error reporting
    
    Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
    chmouel authored and savitaashture committed Jul 4, 2025
    Configuration menu
    Copy the full SHA
    0510f33 View commit details
    Browse the repository at this point in the history
  7. fix: inavlidate empty commits in push events in bitbucket dc

    invalidated empty commits in push in bitbucket data center
    as we may want to check commit field for commit SHA.
    
    Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
    zakisk authored and savitaashture committed Jul 4, 2025
    Configuration menu
    Copy the full SHA
    3dc9d63 View commit details
    Browse the repository at this point in the history
  8. fix: issue in on-path-change on pr merge in bitbucket data center

    fixed an issue where push pipeline run was not triggering on
    pr merge when pipeline run definition is having on-path-cahnge
    annotation. this was happening due to bitbucket data center
    api behavior that it creates merge commit on pr merge that
    is set as HEAD commit of the branch and when changes for that
    commit is retrieved, they're being received empty because
    merge commit in bitbucket data center doesn't contain code
    changes of its parent.
    
    https://issues.redhat.com/browse/SRVKP-7432
    
    Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
    zakisk authored and savitaashture committed Jul 4, 2025
    Configuration menu
    Copy the full SHA
    71027f9 View commit details
    Browse the repository at this point in the history
  9. fix: migrate from brews to homebrew_casks in goreleaser

    made changes to goreleaser to use homebrews_casks
    instead of brews
    
    Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
    zakisk authored and savitaashture committed Jul 4, 2025
    Configuration menu
    Copy the full SHA
    66d16b3 View commit details
    Browse the repository at this point in the history
  10. fix: use correct event type in log in GetTektonDir func

    this fixes logs message in GetTektonDir func for event
    type.
    
    Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
    zakisk authored and savitaashture committed Jul 4, 2025
    Configuration menu
    Copy the full SHA
    3eac400 View commit details
    Browse the repository at this point in the history
  11. fix(ci): golangci-lint revive var-naming error in linters

    fixed golangci-lint revive var-naming error in linters
    
    Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
    zakisk authored and savitaashture committed Jul 4, 2025
    Configuration menu
    Copy the full SHA
    522240f View commit details
    Browse the repository at this point in the history
  12. chore: Make go-testing PipelineRun targeted by all branches

    this commits changes value of on-target-branch annotation
    in go-testing PipelineRun to make it be triggered when
    any branch is targeted in the PaC repo.
    
    Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
    zakisk authored and savitaashture committed Jul 4, 2025
    Configuration menu
    Copy the full SHA
    0437463 View commit details
    Browse the repository at this point in the history
  13. fix(github): guard checkWebhookSecretValidity against nil response

    Fix nil-pointer panic when /rate_limit returns success without SCIM data
    or when the HTTP response itself is nil.
    Add early err/resp checks and ensure rl and rl.SCIM are non-nil
    before accessing them.
    
    Jira: https://issues.redhat.com/browse/SRVKP-8075
    
    Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
    zakisk authored and savitaashture committed Jul 4, 2025
    Configuration menu
    Copy the full SHA
    165d92a View commit details
    Browse the repository at this point in the history
  14. Release yaml generated from 165d92a for release v0.35.2

    Pipelines as Code CI Robot committed Jul 4, 2025
    Configuration menu
    Copy the full SHA
    25d6e84 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2025

  1. fix: Ignore non-Tekton resources errors reporting

    unmarshal non-Tekton custom resources, such as `ImageDigestMirrorSet`,
    or `StepActions` as PipelineRuns. This caused the PaC bot to post misleading
    "PipelineRun failure" comments on pull requests, even when all CI
    jobs were successful.
    
    This change updates the parsing logic to specifically check for and
    ignore non-Tekton resources found within the `.tekton` directory.
    By skipping these files, we prevent erroneous parsing errors and
    stop the bot from posting false-positive comments.
    
    This resolves the issue where developers were confused by failure
    notifications on otherwise successful PRs, improving the overall
    developer experience by reducing unnecessary noise. The fix ensures
    that comments are only posted for legitimate PipelineRun failures.
    
    Jira: https://issues.redhat.com/browse/SRVKP-8112
    
    Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
    chmouel committed Jul 16, 2025
    Configuration menu
    Copy the full SHA
    238d2cf View commit details
    Browse the repository at this point in the history
  2. fix(homebrew): goreleaser issue and cask install doc

    Signed-off-by: Ben Dronen <dronenb@users.noreply.github.com>
    dronenb authored and chmouel committed Jul 16, 2025
    Configuration menu
    Copy the full SHA
    793677d View commit details
    Browse the repository at this point in the history
  3. Release yaml generated from 793677d for release v0.35.3

    Pipelines as Code CI Robot committed Jul 16, 2025
    Configuration menu
    Copy the full SHA
    842f13c View commit details
    Browse the repository at this point in the history
Loading