Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

chore(*): Refactor pkgs to use pkg/*/errors.go #34

Open
johnsonshi opened this issue Aug 2, 2021 · 0 comments
Open

chore(*): Refactor pkgs to use pkg/*/errors.go #34

johnsonshi opened this issue Aug 2, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@johnsonshi
Copy link
Contributor

Files in different osm-health pkgs return errors that indicate different osm issues. It would be a good idea to refactor all return fmt.Errorf to use errors defined in pkg/*/errors.go.

See pkg/envoy/errors.go and pkg/kubernetes/pod/errors.go for examples.
@johnsonshi johnsonshi added enhancement New feature or request good first issue Good for newcomers labels Aug 2, 2021
@johnsonshi johnsonshi mentioned this issue Aug 5, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor errors to errors.go files johnsonshi/osm-health
1 participant
@johnsonshi