-
Notifications
You must be signed in to change notification settings - Fork 176
Update PPL Command Documentation #4562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ritvi Bhatt <ribhatt@amazon.com>
Signed-off-by: Ritvi Bhatt <ribhatt@amazon.com>
Signed-off-by: Ritvi Bhatt <ribhatt@amazon.com>
Signed-off-by: ritvibhatt <53196324+ritvibhatt@users.noreply.github.com>
Signed-off-by: Ritvi Bhatt <ribhatt@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ritvibhatt , thanks for the change. And I can signoff for rex
, regex
, and parse
. And I just left some minor comments.
================================== ============ ============ | ||
|
||
|
||
Limitations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that in the regex.rst
, there are some formatting changes in the "Limitation" section, and I was wondering do we need to apply the same here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the format is good, I removed the first sentence in limitations but let me know if you think format can be changed to match regex better
docs/user/ppl/cmd/append.rst
Outdated
============ | ||
| Using ``append`` command to append the result of a sub-search and attach it as additional rows to the bottom of the input search results (The main search). | ||
| The ``append`` command appends the result of a sub-search and attaches it as additional rows to the bottom of the input search results (The main search). | ||
The command aligns columns with the same field names and types. For different column fields between the main search and sub-search, NULL values are filled in the respective rows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a |
before head of this line.
docs/user/ppl/cmd/appendcol.rst
Outdated
Version | ||
======= | ||
3.1.0 | ||
| The ``appendcol`` command appends the result of a sub-search and attaches it alongside with the input search results (The main search). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to keep the |
any more if there is single line in description. |
means starting from a new line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed all the |
where there was only a single line thanks!
docs/user/ppl/cmd/dedup.rst
Outdated
============ | ||
| Using ``dedup`` command to remove identical document defined by field from the search result. | ||
| The ``dedup`` command removes duplicate documents defined by specified fields from the search result. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
docs/user/ppl/cmd/describe.rst
Outdated
Syntax | ||
============ | ||
describe <dataSource>.<schema>.<tablename> | ||
describe [dataSource].[schema].<tablename> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be describe [dataSource.][schema.]<tablename>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
docs/user/ppl/cmd/expand.rst
Outdated
1. It generates one row per element in the specified array field. | ||
2. The specified array field is converted into individual rows. | ||
3. If an alias is provided, the expanded values appear under the alias instead of the original field name. | ||
4. If the specified field is an empty array, the row is retained with the expanded field set to null. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not bullet mark here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right bullet points make more sense here, updated
====== | ||
|
||
fillnull with <replacement> [in <field-list>] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you delete new line, please add |
at the beginning of each line.
fillnull with <replacement> [in <field-list>] | ||
|
||
fillnull using <field> = <replacement> [, <field> = <replacement>] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
docs/user/ppl/cmd/fillnull.rst
Outdated
|
||
Example 1: Replace null values with a specified value on one field | ||
------------------------------------------------------------------- | ||
=================================================================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete last =
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated all of the =
and -
underlines to match
docs/user/ppl/cmd/fillnull.rst
Outdated
|
||
Example 2: Replace null values with a specified value on multiple fields | ||
------------------------------------------------------------------------- | ||
========================================================================= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto and following
|
||
For extended syntax (join with field list) in 3.3.0, when duplicate-named fields in output results are deduplicated, the fields in output determined by the value of 'overwrite' option. | ||
|
||
Since 3.3.0, join types ``inner``, ``left``, ``outer`` (alias of ``left``), ``semi`` and ``anti`` are supported by default. ``right``, ``full``, ``cross`` are performance sensitive join types which are disabled by default. Set config ``plugins.calcite.all_join_types.allowed = true`` to enable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this information (how to enable full capability of join types) totally lost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was mistakenly deleted thanks for catching that! Added back
docs/user/ppl/cmd/lookup.rst
Outdated
Example 3: no inputField | ||
======================== | ||
Example 3: No inputField specified | ||
==================================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete last two =
docs/user/ppl/cmd/lookup.rst
Outdated
Example 4: outputField as a new field | ||
===================================== | ||
Example 4: OutputField as a new field | ||
====================================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete last one =
docs/user/ppl/cmd/patterns.rst
Outdated
Change default pattern method | ||
============ | ||
Change the default pattern method | ||
============================= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add 4 =
docs/user/ppl/cmd/patterns.rst
Outdated
+-----------------------------------------------------------------------------------------------------------------------------+---------------------------------------------------------------------------------------------------+ | ||
|
||
Simple Pattern Example 3: Extract log patterns with custom regex pattern | ||
========================================================= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add more =
docs/user/ppl/cmd/patterns.rst
Outdated
Configuration | ||
------------- | ||
With Calcite specific option ``show_numbered_token`` enabled, the output can detect numbered variable tokens from the pattern field. | ||
With option ``show_numbered_token`` enabled, the output can detect numbered variable tokens from the pattern field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete one space between With
and option
docs/user/ppl/cmd/sort.rst
Outdated
|
||
Example 8: Sort with specifying field type | ||
Example 9: Sort with specifying field type | ||
================================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
docs/user/ppl/cmd/spath.rst
Outdated
+----------+---+ | ||
|
||
Example 2: Lists & Nesting | ||
============================ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=
problem
docs/user/ppl/cmd/stats.rst
Outdated
"plugins.calcite.enabled" : true | ||
} | ||
}' | ||
* aggregation: mandatory. An aggregation function. The argument of aggregation must be field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The argument of aggregation must be field.
can be removed
docs/user/ppl/cmd/subquery.rst
Outdated
============= | ||
subquery (aka subsearch) | ||
subquery | ||
============= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=
problem
docs/user/ppl/cmd/timechart.rst
Outdated
3.3.0 | ||
|
||
Syntax | ||
============ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=
problem
Signed-off-by: Ritvi Bhatt <ribhatt@amazon.com>
Signed-off-by: Ritvi Bhatt <ribhatt@amazon.com>
Signed-off-by: ritvibhatt <53196324+ritvibhatt@users.noreply.github.com>
Signed-off-by: Ritvi Bhatt <ribhatt@amazon.com>
Signed-off-by: Ritvi Bhatt <ribhatt@amazon.com>
Signed-off-by: Ritvi Bhatt <ribhatt@amazon.com>
Hi @ritvibhatt, thanks for the changes! Quick question: should we also update the documentation in |
This PR standardizes the structure and content of PPL command documentation files to improve consistency and user experience.
Changes Made
Documentation Structure Standardization
Implemented consistent section ordering across all PPL command files:
Content Cleanup and Modernization
3.3.0") to keep documentation current and reduce maintenance overhead
functions file (
/functions/aggregations.rst
) for better organizationRelated Issues
Resolves #[Issue number to be closed when this PR is merged]
#4220
Check List
--signoff
or-s
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.