Ehance dynamic source clause to support metadata only filters #4554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamsimanohar
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
RyanL1997,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az,
ykmr1224 and
yuancu
as code owners
vamsimanohar
force-pushed
the
cwsource
branch
from
25c7c1b to
8c4582e
Compare
vamsimanohar
changed the title
vamsimanohar
force-pushed
the
cwsource
branch
from
8c4582e to
ca60bb2
Compare
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
vamsimanohar
force-pushed
the
cwsource
branch
from
ca60bb2 to
ad163b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow up PR for #4116
Where we support dynamic source clauses with only metadata filters.
We can already achieve this by writing
source = [
*, filterIndex in (httpstatus) ]With this PR, this can be simplified to
source = [filterIndex in (httpstatus) ]
If there is no source reference, this assumes all indices.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.