[Calcite Engine] Support alias type field #3538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heng Qian <qianheng@amazon.com>
qianheng-aws
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
seankao-az and
ykmr1224
as code owners
penghuo
previously approved these changes
Apr 11, 2025
| executeQuery( | ||
| String.format( | ||
| "source=%s | where alias_col > 1 " + "| fields original_col, alias_col ", | ||
| "source=%s | eval a = 1 | where alias_col > 1 | fields original_col, alias_col ", |
There was a problem hiding this comment.
why need a=1?
Avoid the filter push down to ensure the PR really works.
There was a problem hiding this comment.
Please add a test in our standalone IT which could ensure the pushdown w/wo always works. The eval a=1 in future will trigger push down as well.
Signed-off-by: Heng Qian <qianheng@amazon.com>
LantaoJin
approved these changes
Apr 14, 2025
penghuo
approved these changes
Apr 14, 2025
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
* [Calcite Engine] Support alias type field Signed-off-by: Heng Qian <qianheng@amazon.com> * Add standalone IT to ensure w/wo push down test cases Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com> Signed-off-by: xinyual <xinyual@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support alias type.
Since Calcite's logical fields is strictly binding to an offset of its physical array, we have to use an approach different from v2(#3246) but more like the implementation in opensearch-spark(opensearch-project/opensearch-spark#1032).
Related Issues
Resolves #3397
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.