Skip to content

Add SQLQuery Utils support for Vaccum queries #3269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2025
Merged

Add SQLQuery Utils support for Vaccum queries #3269

merged 3 commits into from
Apr 11, 2025

Conversation

@Siritejagaddameedi
Copy link
Contributor

@Siritejagaddameedi Siritejagaddameedi commented Jan 28, 2025 •
edited
Loading

Description

Add SQLQueryUtils support for Vacuum queries

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

  1. SQLQueryUtils didn't support for Vacuum queries

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ykmr1224
ykmr1224 reviewed Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@ykmr1224 ykmr1224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add DCO, and unit tests.

@ykmr1224 ykmr1224 added enhancement New feature or request backport 2.x labels Jan 28, 2025
@ykmr1224
Copy link
Collaborator

Build failed due to style check.

noCharger
noCharger reviewed Jan 29, 2025
View reviewed changes
async-query-core/src/main/java/org/opensearch/sql/spark/utils/SQLQueryUtils.java
Comment on lines 318 to 343
@Override
public Void visitVacuumCoveringIndexStatement(
FlintSparkSqlExtensionsParser.VacuumCoveringIndexStatementContext ctx) {
indexQueryDetailsBuilder.indexQueryActionType(IndexQueryActionType.VACUUM);
indexQueryDetailsBuilder.indexType(FlintIndexType.COVERING);
return super.visitVacuumCoveringIndexStatement(ctx);
}

@Override
public Void visitVacuumSkippingIndexStatement(
FlintSparkSqlExtensionsParser.VacuumSkippingIndexStatementContext ctx) {
indexQueryDetailsBuilder.indexQueryActionType(IndexQueryActionType.VACUUM);
indexQueryDetailsBuilder.indexType(FlintIndexType.SKIPPING);
return super.visitVacuumSkippingIndexStatement(ctx);
}

@Override
public Void visitVacuumMaterializedViewStatement(
FlintSparkSqlExtensionsParser.VacuumMaterializedViewStatementContext ctx) {
indexQueryDetailsBuilder.indexQueryActionType(IndexQueryActionType.VACUUM);
indexQueryDetailsBuilder.indexType(FlintIndexType.MATERIALIZED_VIEW);
indexQueryDetailsBuilder.mvName(ctx.mvName.getText());
return super.visitVacuumMaterializedViewStatement(ctx);
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the use case for adding Vaccum in async-query-core?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever we call SQLQueryUtils with vacuum query, it will fail to parse the query.

ykmr1224
ykmr1224 requested changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@ykmr1224 ykmr1224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to make this change against main branch instead of 2.x and we'll backport to 2.x once merged.

@Siritejagaddameedi Siritejagaddameedi changed the base branch from 2.x to main January 31, 2025 04:18
@Siritejagaddameedi Siritejagaddameedi changed the base branch from main to 2.x January 31, 2025 04:18
@Siritejagaddameedi Siritejagaddameedi changed the base branch from 2.x to main February 6, 2025 05:35
@Siritejagaddameedi Siritejagaddameedi changed the base branch from main to 2.x February 6, 2025 05:40
@ykmr1224 ykmr1224 mentioned this pull request Feb 7, 2025
Closed
7 tasks
@Siritejagaddameedi Siritejagaddameedi changed the base branch from 2.x to main April 8, 2025 04:56
noCharger
noCharger reviewed Apr 8, 2025
View reviewed changes
Copy link
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! Let's fix the DCO and add the necessary test cases, for example https://github.com/opensearch-project/sql/pull/2985/files#diff-4aba5e85641e1ff025d49ef65ad0eb29a5db4bb00d4a3d3f90ccf55a925b5a8f

Add SQLQuery Utils support for Vaccum queries
532e90a 
Signed-off-by: Siri Teja Gaddameedi <sirigadd@amazon.com>

Add UTs

Signed-off-by: Siri Teja Gaddameedi <sirigadd@amazon.com>

Fix build

Signed-off-by: Siri Teja Gaddameedi <sirigadd@amazon.com>

Fix code style

Signed-off-by: Siri Teja Gaddameedi <sirigadd@amazon.com>
@noCharger noCharger merged commit e23a61d into opensearch-project:main Apr 11, 2025
22 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 11, 2025
@github-actions
Add SQLQuery Utils support for Vaccum queries (#3269)
9524cdd 
Add UTs

Fix build

Fix code style

Signed-off-by: Siri Teja Gaddameedi <sirigadd@amazon.com>
Co-authored-by: Siri Teja Gaddameedi <sirigadd@amazon.com>
(cherry picked from commit e23a61d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 11, 2025
Merged
noCharger pushed a commit that referenced this pull request Apr 21, 2025
@opensearch-trigger-bot @github-actions
Add SQLQuery Utils support for Vaccum queries (#3269) (#3540)
9b9b20d 
Add UTs

Fix build

Fix code style



(cherry picked from commit e23a61d)

Signed-off-by: Siri Teja Gaddameedi <sirigadd@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Siri Teja Gaddameedi <sirigadd@amazon.com>
@xinyual xinyual mentioned this pull request Jun 11, 2025
Merged
7 tasks
penghuo pushed a commit that referenced this pull request Jun 16, 2025
@Siritejagaddameedi @xinyual
Add SQLQuery Utils support for Vaccum queries (#3269)
8a33adc 
Add UTs

Fix build

Fix code style

Signed-off-by: Siri Teja Gaddameedi <sirigadd@amazon.com>
Co-authored-by: Siri Teja Gaddameedi <sirigadd@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ykmr1224 ykmr1224 ykmr1224 approved these changes

@noCharger noCharger noCharger approved these changes

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

@LantaoJin LantaoJin Awaiting requested review from LantaoJin LantaoJin is a code owner

@qianheng-aws qianheng-aws Awaiting requested review from qianheng-aws qianheng-aws is a code owner

Assignees

No one assigned

Labels

backport 2.x enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Siritejagaddameedi @ykmr1224 @noCharger