Fixed DateTimeFunctionTest.testWeekOfYearWithTimeType and YearWeekTestt.testYearWeekWithTimeType Test Failures #3235
Conversation
…t.testYearWeekWithTimeType test failures Signed-off-by: Kenrick Yap <kenrick.yap@improving.com>
kenrickyap
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224,
LantaoJin and
noCharger
as code owners
| @@ -1232,26 +1234,37 @@ public void testWeekFormats( | |||
| // Issue: https://github.com/opensearch-project/sql/issues/2477 | |||
| @Test | |||
| public void testWeekOfYearWithTimeType() { | |||
| // The following calculation is needed to correct the discrepancy in how ISO 8601 | |||
There was a problem hiding this comment.
Can we move this logic to a common test util class to avoid duplication?
Unfortunately, neither YearweekTest nor DateTimeFunctionTest extends DateTimeTestBase. But I think that might be a good place to move the function (maybe as a static method?) unless you can find a better place.
Signed-off-by: Kenrick Yap <kenrick.yap@improving.com>
|
@kenrickyap could this patch address the flaky test listed in and workaround by PR #3225? If yes, please update that test too. |
@LantaoJin I have tried to apply the same logic but for some reason the unit test is still failing after I remove the check for January and December. Will spend a little more time to find a solution! |
Description
Certain tests failed due to inconsistencies with how ISO 8601 and how opensearch sql calculates number of weeks since start of year. Specifically ISO 8601 calculates weeks using the following criteria:
Whereas YEARWEEK counts only full weeks, where weeks start on Sunday. To fix the discrepancy we find the first Sunday of the year and start counting weeks from that date.
Related Issues
Resolves #2477
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.