Implement vacuum index operation #2557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2557 +/- ##
============================================
- Coverage 95.53% 95.50% -0.03%
- Complexity 5101 5113 +12
============================================
Files 488 489 +1
Lines 14261 14310 +49
Branches 958 961 +3
============================================
+ Hits 13624 13667 +43
- Misses 614 618 +4
- Partials 23 25 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
commented
Mar 15, 2024
Signed-off-by: Chen Dai <daichen@amazon.com>
|
Will address conflicts once #2554 merged |
dai-chen
requested review from
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
penghuo,
ps48,
rupal-bq,
seankao-az and
vamsimanohar
as code owners
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
penghuo
approved these changes
Mar 19, 2024
| stateStore, dispatchQueryRequest.getDatasource(), emrServerlessClient); | ||
| try { | ||
| tryDropOp.apply(indexMetadata); | ||
| } catch (IllegalStateException e) { |
There was a problem hiding this comment.
Do we want to ignore only IllegalStateException or any kind of error?
There was a problem hiding this comment.
I think only the IllegalStateException thrown from validation? If any exception occurred during operation and commit, there is no need to continue.
vamsimanohar
approved these changes
Mar 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Add vacuum operation and IT Signed-off-by: Chen Dai <daichen@amazon.com> * Add index state doc delete and more IT Signed-off-by: Chen Dai <daichen@amazon.com> * Refactor IT Signed-off-by: Chen Dai <daichen@amazon.com> * Fix bytebuddy version conflict Signed-off-by: Chen Dai <daichen@amazon.com> * Fix broken IT Signed-off-by: Chen Dai <daichen@amazon.com> * Fix broken IT Signed-off-by: Chen Dai <daichen@amazon.com> * Fix jacoco failure with new IT Signed-off-by: Chen Dai <daichen@amazon.com> * Fix code format Signed-off-by: Chen Dai <daichen@amazon.com> * Fix jacoco test coverage Signed-off-by: Chen Dai <daichen@amazon.com> --------- Signed-off-by: Chen Dai <daichen@amazon.com> (cherry picked from commit 8374cb6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dai-chen
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Add vacuum operation and IT * Add index state doc delete and more IT * Refactor IT * Fix bytebuddy version conflict * Fix broken IT * Fix broken IT * Fix jacoco failure with new IT * Fix code format * Fix jacoco test coverage --------- (cherry picked from commit 8374cb6) Signed-off-by: Chen Dai <daichen@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented the
VACUUMindex statement in the plugin. The semantics slightly differ from what's defined in Flint Spark: similar to the currentDROPindex logic in the plugin, the vacuum operation can transition fromREFRESHING,ACTIVE, orDELETEDstates directly, instead of only acceptingDELETED.Issues Resolved
opensearch-project/opensearch-spark#104
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.