Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JDK-21 to GA worklflows #2481

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Add JDK-21 to GA worklflows #2481

merged 1 commit into from
Feb 6, 2024

Conversation

reta
Copy link
Contributor

@reta reta commented Jan 25, 2024 •
edited
Loading

Description

Add JDK-21 to GA worklflows

Issues Resolved

Part of opensearch-project/OpenSearch#10334

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vamsi-amazon
Copy link
Member

Merged #2476.
Rerunning failed workflows.

vamsi-amazon
vamsi-amazon reviewed Jan 25, 2024
View reviewed changes
.github/workflows/integ-tests-with-security.yml
@@ -20,7 +20,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ 11, 17 ]
java: [ 11, 17, 21 ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reta are we going to start supporting 21 in next 2.x version? Lets suppose if 3.0 release is near by can we skip supporting 2.x? How do we make these decisions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reta are we going to start supporting 21 in next 2.x version? Lets suppose if 3.0 release is near by can we skip supporting 2.x? How do we make these decisions?

@vamsi-amazon 2.12.0 is going to be bundled with JDK-21, see please opensearch-project/OpenSearch#10334, opensearch-project/OpenSearch#11003. The context for it - JDK-21 is the next LTS and there is new vector APIs that Apache Lucene and OpenSearch benefit from, including plugins. Thank you.

Copy link
Contributor Author

@reta reta Jan 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets suppose if 3.0 release is near by can we skip supporting 2.x?

I think when 3.0 is out, than 2.x would go to a maintenance mode, as 1.3.x is these days (but fairly speaking, we are just kicking off the discussions to understand when 3.0 could be out). Thank you.

vamsi-amazon
vamsi-amazon previously approved these changes Jan 25, 2024
View reviewed changes
@reta reta mentioned this pull request Feb 6, 2024
Merged
vamsi-amazon
vamsi-amazon previously approved these changes Feb 6, 2024
View reviewed changes
penghuo
penghuo previously approved these changes Feb 6, 2024
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f30aea) 95.41% compared to head (51a85df) 95.41%.
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #2481   +/-   ##
=========================================
  Coverage     95.41%   95.41%           
- Complexity     5000     5026   +26     
=========================================
  Files           479      483    +4     
  Lines         13950    14005   +55     
  Branches        937      944    +7     
=========================================
+ Hits          13310    13363   +53     
- Misses          618      621    +3     
+ Partials         22       21    -1
Flag Coverage Δ
sql-engine 95.41% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta @vamsi-amazon
Add JDK-21 to GA worklflows
51a85df 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Fix functions.rst for JDK 21

Signed-off-by: Peng Huo <penghuo@gmail.com>
@vamsi-amazon vamsi-amazon dismissed stale reviews from penghuo and themself via 51a85df February 6, 2024 07:04
@vamsi-amazon vamsi-amazon added the v2.12.0 Issues targeting release v2.12.0 label Feb 6, 2024
@vamsi-amazon vamsi-amazon merged commit 2a3ebea into opensearch-project:main Feb 6, 2024
28 of 29 checks passed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 6, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2024
@github-actions
Add JDK-21 to GA worklflows (#2481)
4d6f8fc 
Fix functions.rst for JDK 21

Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 2a3ebea)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@reta reta mentioned this pull request Feb 6, 2024
Closed
95 tasks
vamsi-amazon pushed a commit that referenced this pull request Feb 6, 2024
@opensearch-trigger-bot @github-actions
Add JDK-21 to GA worklflows (#2481) (#2509)
db45846 
Fix functions.rst for JDK 21


(cherry picked from commit 2a3ebea)

Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vamsi-amazon vamsi-amazon vamsi-amazon approved these changes

@penghuo penghuo penghuo approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

Assignees

@reta reta

@vamsi-amazon vamsi-amazon

Labels
backport 2.x v2.12.0 Issues targeting release v2.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reta @vamsi-amazon @penghuo