Add sec_to_time Function To OpenSearch SQL
#1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added Tests Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Added Implementation And Documentation Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Added Integration Test And Fixed Checkstyle Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Addressed PR Comments Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Fixed Checkstyle Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Added Tests And Modified Docs Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Fixed formatNanos Helper Function Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Temporarily Removed Failing Tests Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Fixed Nanoseconds Float/Double Imprecision Issues Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Fixed Checkstyle Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Added Tests Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Altered Implementation To Use BigDecimal Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> --------- Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
87 tasks
MaxKsyunz
approved these changes
Mar 9, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1378 +/- ##
=========================================
Coverage 98.38% 98.39%
- Complexity 3698 3703 +5
=========================================
Files 343 343
Lines 9121 9136 +15
Branches 586 586
=========================================
+ Hits 8974 8989 +15
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
matthewryanwells
approved these changes
Mar 13, 2023
Yury-Fridlyand
approved these changes
Mar 15, 2023
dai-chen
approved these changes
Mar 15, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2023
* Added Tests * Added Implementation And Documentation * Added Integration Test And Fixed Checkstyle * Addressed PR Comments * Fixed Checkstyle * Added Tests And Modified Docs * Fixed formatNanos Helper Function * Temporarily Removed Failing Tests * Fixed Nanoseconds Float/Double Imprecision Issues * Fixed Checkstyle * Added Tests * Altered Implementation To Use BigDecimal --------- Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> (cherry picked from commit aa7f90e)
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Mar 16, 2023
* Added Tests * Added Implementation And Documentation * Added Integration Test And Fixed Checkstyle * Addressed PR Comments * Fixed Checkstyle * Added Tests And Modified Docs * Fixed formatNanos Helper Function * Temporarily Removed Failing Tests * Fixed Nanoseconds Float/Double Imprecision Issues * Fixed Checkstyle * Added Tests * Altered Implementation To Use BigDecimal --------- Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> (cherry picked from commit aa7f90e) Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
sec_to_timefunction to the OpenSearch SQL plugin. It is based on MySQL documentation, but it does not allow negative dates.Issues Resolved
#722
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.