[Backport 2.x] Modified returning NaN to NULL #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GumpacG
changed the title
acarbonetto
previously approved these changes
Feb 15, 2023
Yury-Fridlyand
requested changes
Feb 15, 2023
|
Compilation is failing due to dependency on #1348. Will rebase once PR 1348 is merged. |
|
@GumpacG try to rebase now. |
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> (cherry picked from commit de40f42)
GumpacG
force-pushed
the
backport/backport-1341-to-2.x
branch
from
ca0bb50
to
0ba718a
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #1347 +/- ##
=========================================
Coverage 98.38% 98.38%
- Complexity 3692 3698 +6
=========================================
Files 345 345
Lines 9107 9112 +5
Branches 585 585
=========================================
+ Hits 8960 8965 +5
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@Yury-Fridlyand should be good now |
Yury-Fridlyand
approved these changes
Feb 16, 2023
dai-chen
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guian Gumpac guian.gumpac@improving.com
(cherry picked from commit de40f42) from #1341
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.