Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage of Strings.toString #1309

Merged

Conversation

MaxKsyunz
Copy link
Collaborator

@MaxKsyunz MaxKsyunz commented Jan 30, 2023

Description

Changed calls of Strings.toString to match the new signature. See opensearch-project/OpenSearch#6009

Issues Resolved

#1308

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Changed calls of Strings.toString to match the new signature.

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
@MaxKsyunz MaxKsyunz requested a review from a team as a code owner January 30, 2023 19:47
@Yury-Fridlyand
Copy link
Collaborator

You have to fix legacy unit tests as well

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
@Yury-Fridlyand Yury-Fridlyand merged commit 6108ca1 into opensearch-project:main Jan 30, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the integ-Strings.toString branch January 30, 2023 21:17
@dai-chen dai-chen added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Feb 6, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 7, 2023
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
(cherry picked from commit 6108ca1)
MaxKsyunz pushed a commit that referenced this pull request Mar 7, 2023
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
(cherry picked from commit 6108ca1)
penghuo pushed a commit that referenced this pull request Mar 8, 2023
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
(cherry picked from commit 6108ca1)

Co-authored-by: Max Ksyunz <maxk@bitquilltech.com>
penghuo added a commit to penghuo/os-sql that referenced this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants