Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Use SQL CLI tool from pipy in doctest gradle task #1281

Open
Yury-Fridlyand opened this issue Jan 17, 2023 · 0 comments
Open

[FEATURE] Use SQL CLI tool from pipy in doctest gradle task #1281

Yury-Fridlyand opened this issue Jan 17, 2023 · 0 comments
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Comments

@Yury-Fridlyand
Copy link
Collaborator

Is your feature request related to a problem?

sql/doctest/build.gradle

Lines 22 to 33 in 9d4a841

task cloneSqlCli(type: Exec) {
// clone the sql-cli repo locally
commandLine 'git', 'clone', 'https://github.com/opensearch-project/sql-cli.git'
}
task bootstrap(type: Exec, dependsOn: ['cloneSqlCli']) {
inputs.file "$projectDir/bootstrap.sh"
outputs.dir "$projectDir/.venv"
commandLine 'sh', "$projectDir/bootstrap.sh"
}

Currently, doctest gradle task clones sql-cli repo.

What solution would you like?
Install sql cli tool from pipy using pip.

What alternatives have you considered?
N/A

Do you have any additional context?
Make doctest more robust too. It can't start if it crashed or interrupted by Ctrl+C without manual cleanup.

@Yury-Fridlyand Yury-Fridlyand added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Jan 17, 2023
@Yury-Fridlyand Yury-Fridlyand changed the title [FEATURE] Use SQL CLI too from pipy in doctest gradle task [FEATURE] Use SQL CLI tool from pipy in doctest gradle task Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

No branches or pull requests

1 participant