Skip to content

[FEATURE] Add new CI workflow for PRs to run tests on base branch. #1242

Open
@Yury-Fridlyand

Description

@Yury-Fridlyand

A situation might happen when a good PRs1 was merged2 into a base branch cause a failure after merge.
This happened recently with #1166.
image

Existing PR CI workflows run on top of the feature branch only. Merging PR cause a merge commit which triggers another CI which might fail, but it doesn't block the PR, because it is already merged... Furthermore, detect such failures is much more difficult in tons of GHA notifications.

The feature I request is to add a new CI workflow which will run in each PR and test proposed changes on base branch.

  1. Workflow would be like:
git checkout <base branch>
git merge <pr branch>
./gradlew ...
  1. Workflow could run simplified test suite (e.g. integration tests only).
  2. Workflow should run on every change in base or feature branch, see pull_request_target

Footnotes

  1. All CI passed on feature branches

  2. Without any conflicts

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestinfrastructureChanges to infrastructure, testing, CI/CD, pipelines, etc.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions