Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Track new engine test coverage #1144

Open
MaxKsyunz opened this issue Dec 6, 2022 · 2 comments
Open

[FEATURE] Track new engine test coverage #1144

MaxKsyunz opened this issue Dec 6, 2022 · 2 comments
Labels
enhancement New feature or request infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. new-engine-gap

Comments

@MaxKsyunz
Copy link
Collaborator

Is your feature request related to a problem?
As a developer, I'd like to know when the v2 SQL engine has the same test coverage as the legacy engine.

We can begin planning deprecation of the legacy engine once this test coverage parity is reached.

What solution would you like?
A separate workflow that runs SQL plugin unit, integration, and doc tests with v2 engine only.

Test reports to be published as part of run results using an action such as

@MaxKsyunz MaxKsyunz added enhancement New feature or request infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. untriaged new-engine-gap labels Dec 6, 2022
@acarbonetto
Copy link
Collaborator

This would be helpful to track #787

@MaxKsyunz
Copy link
Collaborator Author

@acarbonetto @dai-chen

Let's have a "deprecate v1 engine" feature branch and update SQL Java CI workflow to track test coverage.

We need some way to run tests without V1 engine. The common way to implement this is via feature flags. However these would be run-time options (either JVM options or Spring feature toggles) and that's something we are trying to avoid.

It will be a bit of extra work to keep the branch up-to-date with most recent development branch, but I expect fast-forward merge will work most of the time and in the end, removing V1 engine will be trivial -- just merge the feature branch into dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. new-engine-gap
Projects
None yet
Development

No branches or pull requests

3 participants