Fix failed test in AbstractRetrieverToolTests

yuancu · yuancu · commit eec38d632131 · 2025-08-08T21:26:36.000+08:00
Signed-off-by: Yuanchun Shen &lt;yuanchu@amazon.com&gt;
diff --git a/src/test/java/org/opensearch/agent/tools/AbstractRetrieverToolTests.java b/src/test/java/org/opensearch/agent/tools/AbstractRetrieverToolTests.java
@@ -165,7 +165,9 @@ public void testRunAsyncWithIllegalQueryThenListenerOnFailure() {
         mockedImpl.run(null, listener4);
 
         Exception exception4 = assertThrows(Exception.class, future4::join);
-        assertTrue(exception4.getCause() instanceof NullPointerException);
+        // parameter is re-created with extractInputParameters, thus will not be null
+        assertTrue(exception4.getCause() instanceof IllegalArgumentException);
+        assertEquals(exception4.getCause().getMessage(), "[input] is null or empty, can not process it.");
     }
 
     @Test

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,9 @@ public void testRunAsyncWithIllegalQueryThenListenerOnFailure() {`
`165`	`165`	`mockedImpl.run(null, listener4);`
`166`	`166`
`167`	`167`	`Exception exception4 = assertThrows(Exception.class, future4::join);`
`168`		`- assertTrue(exception4.getCause() instanceof NullPointerException);`
	`168`	`+ // parameter is re-created with extractInputParameters, thus will not be null`
	`169`	`+ assertTrue(exception4.getCause() instanceof IllegalArgumentException);`
	`170`	`+ assertEquals(exception4.getCause().getMessage(), "[input] is null or empty, can not process it.");`
`169`	`171`	`}`
`170`	`172`
`171`	`173`	`@Test`