Skip to content

Conversation

@DarshitChanpura
Copy link
Member

Description

Update the resource visibility update call that was somehow missed in this PR: #5596

  • Category: Bug fix
  • Why these changes are required?
    After patching a resource sharing record, searching will not work for the updated entities as expected as all_shared_principals in the resource document will not be updated without this change.

Testing

Manual + Automated testing

Check List

  • New functionality includes testing
    - [ ] New functionality has been documented
    - [ ] New Roles/Permissions have a corresponding security dashboards plugin PR
    - [ ] API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… record

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
cwperks
cwperks previously approved these changes Sep 25, 2025
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.90%. Comparing base (f944fb4) to head (493c96e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ecurity/resources/ResourceSharingIndexHandler.java 75.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5654   +/-   ##
=======================================
  Coverage   72.89%   72.90%           
=======================================
  Files         413      413           
  Lines       25750    25758    +8     
  Branches     3917     3917           
=======================================
+ Hits        18771    18778    +7     
- Misses       5064     5065    +1     
  Partials     1915     1915           
Files with missing lines Coverage Δ
...ecurity/resources/ResourceSharingIndexHandler.java 69.29% <75.00%> (-0.80%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cwperks cwperks merged commit e8a82af into opensearch-project:main Sep 25, 2025
124 of 125 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants