Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove hard coded action names, pull from core instead #4515

Open
derek-ho opened this issue Jul 2, 2024 · 1 comment
Open

[FEATURE] Remove hard coded action names, pull from core instead #4515

derek-ho opened this issue Jul 2, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@derek-ho
Copy link
Collaborator

derek-ho commented Jul 2, 2024

Is your feature request related to a problem?
Hard coded action names like: https://github.com/opensearch-project/security/blob/main/src/main/java/org/opensearch/security/privileges/SecurityIndexAccessEvaluator.java#L113 should not exist, and instead we should pull from core. That way if there are future changes we are insulated.
What solution would you like?
Pull action names from core
What alternatives have you considered?
None
Do you have any additional context?
No

@derek-ho derek-ho added enhancement New feature or request untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jul 2, 2024
@derek-ho derek-ho self-assigned this Jul 2, 2024
@stephen-crawford
Copy link
Contributor

[Triage] HI @derek-ho thanks for filing this issue. This seems like a smart change so going to mark as triaged.

@stephen-crawford stephen-crawford added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Development

No branches or pull requests

2 participants