Deprecate plugins.security.system_indices.indices

Signed-off-by: Craig Perkins <cwperx@amazon.com>

Author: cwperks

src/main/java/org/opensearch/security/OpenSearchSecurityPlugin.java

@@ -1421,7 +1421,8 @@ public List<Setting<?>> getSettings() {
                 Function.identity(),
                 Property.NodeScope,
                 Property.Filtered,
-                Property.Final
+                Property.Final,
+                Property.Deprecated
             )
         );
 

src/main/java/org/opensearch/security/tools/democonfig/SecuritySettingsConfigurer.java

@@ -45,40 +45,6 @@
 public class SecuritySettingsConfigurer {
 
     static final List<String> REST_ENABLED_ROLES = List.of("all_access", "security_rest_api_access");
-    static final List<String> SYSTEM_INDICES = List.of(
-        ".plugins-ml-agent",
-        ".plugins-ml-config",
-        ".plugins-ml-connector",
-        ".plugins-ml-controller",
-        ".plugins-ml-model-group",
-        ".plugins-ml-model",
-        ".plugins-ml-task",
-        ".plugins-ml-conversation-meta",
-        ".plugins-ml-conversation-interactions",
-        ".plugins-ml-memory-meta",
-        ".plugins-ml-memory-message",
-        ".plugins-ml-stop-words",
-        ".opendistro-alerting-config",
-        ".opendistro-alerting-alert*",
-        ".opendistro-anomaly-results*",
-        ".opendistro-anomaly-detector*",
-        ".opendistro-anomaly-checkpoints",
-        ".opendistro-anomaly-detection-state",
-        ".opendistro-reports-*",
-        ".opensearch-notifications-*",
-        ".opensearch-notebooks",
-        ".opensearch-observability",
-        ".ql-datasources",
-        ".opendistro-asynchronous-search-response*",
-        ".replication-metadata-store",
-        ".opensearch-knn-models",
-        ".geospatial-ip2geo-data*",
-        ".plugins-flow-framework-config",
-        ".plugins-flow-framework-templates",
-        ".plugins-flow-framework-state",
-        ".plugins-search-relevance-experiment",
-        ".plugins-search-relevance-judgment-cache"
-    );
     static final Integer DEFAULT_PASSWORD_MIN_LENGTH = 8;
     static String ADMIN_PASSWORD = "";
     static String ADMIN_USERNAME = "admin";
@@ -371,7 +337,6 @@ Map<String, Object> buildSecurityConfigMap() {
         configMap.put("plugins.security.restapi.roles_enabled", REST_ENABLED_ROLES);
 
         configMap.put("plugins.security.system_indices.enabled", true);
-        configMap.put("plugins.security.system_indices.indices", SYSTEM_INDICES);
 
         if (!isNetworkHostAlreadyPresent(installer.OPENSEARCH_CONF_FILE)) {
             if (installer.cluster_mode) {

src/test/java/org/opensearch/security/tools/democonfig/SecuritySettingsConfigurerTests.java

@@ -47,7 +47,6 @@
 import static org.opensearch.security.tools.democonfig.SecuritySettingsConfigurer.DEFAULT_ADMIN_PASSWORD;
 import static org.opensearch.security.tools.democonfig.SecuritySettingsConfigurer.DEFAULT_PASSWORD_MIN_LENGTH;
 import static org.opensearch.security.tools.democonfig.SecuritySettingsConfigurer.REST_ENABLED_ROLES;
-import static org.opensearch.security.tools.democonfig.SecuritySettingsConfigurer.SYSTEM_INDICES;
 import static org.opensearch.security.tools.democonfig.SecuritySettingsConfigurer.isKeyPresentInYMLFile;
 import static org.opensearch.security.tools.democonfig.util.DemoConfigHelperUtil.createDirectory;
 import static org.opensearch.security.tools.democonfig.util.DemoConfigHelperUtil.createFile;
@@ -269,7 +268,6 @@ public void testBuildSecurityConfigMap() {
         assertThat(actual.get("plugins.security.check_snapshot_restore_write_privileges"), equalTo(true));
         assertThat(actual.get("plugins.security.restapi.roles_enabled"), equalTo(REST_ENABLED_ROLES));
         assertThat(actual.get("plugins.security.system_indices.enabled"), equalTo(true));
-        assertThat(actual.get("plugins.security.system_indices.indices"), equalTo(SYSTEM_INDICES));
         assertThat(actual.get("node.max_local_storage_nodes"), equalTo(3));
 
         installer.initsecurity = true;