Skip to content

Commit 1bbb420

Browse files
Spotless apply
Signed-off-by: Finn Carroll <carrofin@amazon.com>
1 parent 44cfeb5 commit 1bbb420

File tree

3 files changed

+24
-22
lines changed

3 files changed

+24
-22
lines changed

src/integrationTest/java/org/opensearch/security/api/CertificatesRestApiIntegrationTest.java

Lines changed: 19 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@
3030
import org.opensearch.test.framework.cluster.LocalOpenSearchCluster;
3131
import org.opensearch.test.framework.cluster.TestRestClient;
3232

33-
import static junit.framework.TestCase.fail;
3433
import static org.hamcrest.CoreMatchers.containsString;
3534
import static org.hamcrest.CoreMatchers.is;
3635
import static org.hamcrest.MatcherAssert.assertThat;
3736
import static org.opensearch.security.OpenSearchSecurityPlugin.PLUGINS_PREFIX;
3837
import static org.opensearch.security.dlic.rest.api.RestApiAdminPrivilegesEvaluator.CERTS_INFO_ACTION;
3938
import static org.opensearch.security.support.ConfigConstants.SECURITY_RESTAPI_ADMIN_ENABLED;
39+
import static junit.framework.TestCase.fail;
4040

4141
public class CertificatesRestApiIntegrationTest extends AbstractApiIntegrationTest {
4242
final static String REST_API_ADMIN_SSL_INFO = "rest-api-admin-ssl-info";
@@ -88,7 +88,11 @@ public void forbiddenForAdminUser() throws Exception {
8888

8989
@Test
9090
public void availableForTlsAdmin() throws Exception {
91-
withUser(ADMIN_USER_NAME, localCluster.getAdminCertificate(), verifySSLCertsInfo(List.of(CertType.HTTP, CertType.TRANSPORT, CertType.TRANSPORT_CLIENT)));
91+
withUser(
92+
ADMIN_USER_NAME,
93+
localCluster.getAdminCertificate(),
94+
verifySSLCertsInfo(List.of(CertType.HTTP, CertType.TRANSPORT, CertType.TRANSPORT_CLIENT))
95+
);
9296
}
9397

9498
@Test
@@ -112,14 +116,16 @@ private CheckedConsumer<TestRestClient, Exception> verifySSLCertsInfo(List<CertT
112116
assertSSLCertsInfo(localCluster.nodes(), expectCerts, ok(() -> testRestClient.get(sslCertsPath())));
113117
if (localCluster.nodes().size() > 1) {
114118
final var randomNodes = randomNodes();
115-
final var nodeIds = randomNodes.stream().map(n -> n.esNode().getNodeEnvironment().nodeId()).collect(Collectors.joining(","));
119+
final var nodeIds = randomNodes.stream()
120+
.map(n -> n.esNode().getNodeEnvironment().nodeId())
121+
.collect(Collectors.joining(","));
116122
assertSSLCertsInfo(randomNodes, expectCerts, ok(() -> testRestClient.get(sslCertsPath(nodeIds))));
117123
}
118124
final var randomCertType = randomFrom(expectCerts);
119125
assertSSLCertsInfo(
120-
localCluster.nodes(),
121-
List.of(randomCertType),
122-
ok(() -> testRestClient.get(String.format("%s?cert_type=%s", sslCertsPath(), randomCertType)))
126+
localCluster.nodes(),
127+
List.of(randomCertType),
128+
ok(() -> testRestClient.get(String.format("%s?cert_type=%s", sslCertsPath(), randomCertType)))
123129
);
124130
} catch (Exception e) {
125131
fail("Verify SSLCerts info failed with exception: " + e.getMessage());
@@ -161,22 +167,18 @@ private void assertSSLCertsInfo(
161167

162168
private void verifyCertsJson(final int nodeNumber, final JsonNode jsonNode) {
163169
if (jsonNode.get("subject_dn").asText().contains(ROOT_CA)) { // handle root cert
164-
assertThat(
165-
jsonNode.toPrettyString(),
166-
jsonNode.get("subject_dn").asText(),
167-
is(TestCertificates.CA_SUBJECT)
168-
);
170+
assertThat(jsonNode.toPrettyString(), jsonNode.get("subject_dn").asText(), is(TestCertificates.CA_SUBJECT));
169171
assertThat(jsonNode.toPrettyString(), jsonNode.get("san").asText().isEmpty());
170172
} else { // handle non-root
171173
assertThat(
172-
jsonNode.toPrettyString(),
173-
jsonNode.get("subject_dn").asText(),
174-
is(String.format(TestCertificates.NODE_SUBJECT_PATTERN, nodeNumber))
174+
jsonNode.toPrettyString(),
175+
jsonNode.get("subject_dn").asText(),
176+
is(String.format(TestCertificates.NODE_SUBJECT_PATTERN, nodeNumber))
175177
);
176178
assertThat(
177-
jsonNode.toPrettyString(),
178-
jsonNode.get("san").asText(),
179-
containsString(String.format("node-%s.example.com", nodeNumber))
179+
jsonNode.toPrettyString(),
180+
jsonNode.get("san").asText(),
181+
containsString(String.format("node-%s.example.com", nodeNumber))
180182
);
181183
}
182184
assertThat(jsonNode.toPrettyString(), jsonNode.get("issuer_dn").asText(), is(TestCertificates.CA_SUBJECT));

src/main/java/org/opensearch/security/ssl/config/CertType.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -144,9 +144,9 @@ public Iterator<CertType> iterator() {
144144
public static CertType TRANSPORT_CLIENT = new CertType(SSL_TRANSPORT_CLIENT_PREFIX, "transport_client");
145145
public static CertType TRANSPORT_SERVER = new CertType(SSL_TRANSPORT_SERVER_PREFIX, "transport_server");
146146
public static final NodeCertTypeRegistry CERT_TYPE_REGISTRY = new NodeCertTypeRegistry(
147-
HTTP,
148-
TRANSPORT,
149-
TRANSPORT_CLIENT,
150-
TRANSPORT_SERVER
147+
HTTP,
148+
TRANSPORT,
149+
TRANSPORT_CLIENT,
150+
TRANSPORT_SERVER
151151
);
152152
}

src/test/java/org/opensearch/security/ssl/SslSettingsManagerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@
6666
import static org.opensearch.security.ssl.util.SSLConfigConstants.getBoolAffixKeyForCertType;
6767
import static org.opensearch.security.ssl.util.SSLConfigConstants.getStringAffixKeyForCertType;
6868
import static org.opensearch.security.support.ConfigConstants.SECURITY_SSL_ONLY;
69-
import static org.junit.Assert.assertThrows;
7069
import static org.opensearch.transport.AuxTransport.AUX_TRANSPORT_TYPES_SETTING;
70+
import static org.junit.Assert.assertThrows;
7171

7272
public class SslSettingsManagerTest extends RandomizedTest {
7373

0 commit comments

Comments
 (0)