Skip to content

Commit 08c74d9

Browse files
Minor change in evaluator logic
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
1 parent 3ec629a commit 08c74d9

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/main/java/org/opensearch/security/privileges/ResourceAccessEvaluator.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
import java.util.Set;
1414

15+
import joptsimple.internal.Strings;
1516
import org.apache.logging.log4j.LogManager;
1617
import org.apache.logging.log4j.Logger;
1718

@@ -98,8 +99,8 @@ public boolean shouldEvaluate(ActionRequest request) {
9899
);
99100
if (!isResourceSharingFeatureEnabled) return false;
100101
if (!(request instanceof DocRequest docRequest)) return false;
101-
if (docRequest.id() == null) {
102-
log.debug("Request id is null, request is of type {}", docRequest.getClass().getName());
102+
if (Strings.isNullOrEmpty(docRequest.id())) {
103+
log.debug("Request id is blank or null, request is of type {}", docRequest.getClass().getName());
103104
return false;
104105
}
105106
// if requested index is not a resource sharing index, move on to the regular evaluator

0 commit comments

Comments
 (0)