Use the getRedirectUrl from OSD to generate nextUrl
#2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2072 +/- ##
=======================================
Coverage 71.17% 71.17%
=======================================
Files 96 96
Lines 2598 2598
Branches 380 387 +7
=======================================
Hits 1849 1849
Misses 649 649
Partials 100 100 ☔ View full report in Codecov by Sentry. |
7 tasks
SuZhou-Joe
changed the title
getRedirectUrl from OSD to generate nextUrl
SuZhou-Joe
force-pushed
the
feature/add-get-next-url
branch
from
0b3ed86
to
c8e849c
Compare
SuZhou-Joe
requested review from
cliu123,
cwperks,
DarshitChanpura,
derek-ho and
RyanL1997
as code owners
|
@SuZhou-Joe Can you look into the failing integ test? |
|
@cwperks Sure, fixed because the unit test used to use a simple object to fake OpenSearchDashboardRequest, change that piece to a correct request mock. |
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
force-pushed
the
feature/add-get-next-url
branch
from
436e1d8
to
12d170d
Compare
cwperks
approved these changes
Aug 14, 2024
derek-ho
reviewed
Aug 14, 2024
derek-ho
approved these changes
Aug 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
* feat: consume the get redirect url function from osd core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: consume the get redirect url function from osd core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: failed unit test because of an invalid mocked request Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: failed unit test because of an invalid mocked request Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 371495b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho
added a commit
that referenced
this pull request
Aug 19, 2024
* feat: consume the get redirect url function from osd core * feat: consume the get redirect url function from osd core * fix: failed unit test because of an invalid mocked request * fix: failed unit test because of an invalid mocked request --------- (cherry picked from commit 371495b) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Derek Ho <dxho@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to adopt the util function
getRedirectUrlfrom OSD core to get a unified url after login.This PR should not merged until opensearch-project/OpenSearch-Dashboards#7600 get merged.
Category
Bug fix
Why these changes are required?
#2069
What is the old behavior before changes and new behavior after changes?
Issues Resolved
#2069
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.