Conform to Navigation changes from OSD core #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
feat: enable data source info in new left navigation
17 tasks
SuZhou-Joe
reviewed
Jul 18, 2024
SuZhou-Joe
reviewed
Jul 18, 2024
SuZhou-Joe
approved these changes
Jul 18, 2024
Signed-off-by: Derek Ho <dxho@amazon.com>
…plugin into nav-change
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
requested review from
cliu123,
cwperks,
DarshitChanpura,
RyanL1997 and
stephen-crawford
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2022 +/- ##
==========================================
- Coverage 70.36% 69.34% -1.02%
==========================================
Files 96 96
Lines 2541 2587 +46
Branches 377 375 -2
==========================================
+ Hits 1788 1794 +6
- Misses 660 699 +39
- Partials 93 94 +1 ☔ View full report in Codecov by Sentry. |
stephen-crawford
approved these changes
Jul 18, 2024
DarshitChanpura
approved these changes
Jul 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 19, 2024
* Adopt to nav changes in core Signed-off-by: Derek Ho <dxho@amazon.com> * Lint Signed-off-by: Derek Ho <dxho@amazon.com> * feat: enable data source info in new left navigation Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: enable data source info in new left navigation Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Address PR feedback Signed-off-by: Derek Ho <dxho@amazon.com> * Lint Signed-off-by: Derek Ho <dxho@amazon.com> * Fix lint and tests Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 2f8c6f4)
derek-ho
added a commit
that referenced
this pull request
Jul 19, 2024
* Adopt to nav changes in core Signed-off-by: Derek Ho <dxho@amazon.com> * Lint Signed-off-by: Derek Ho <dxho@amazon.com> * feat: enable data source info in new left navigation Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: enable data source info in new left navigation Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Address PR feedback Signed-off-by: Derek Ho <dxho@amazon.com> * Lint Signed-off-by: Derek Ho <dxho@amazon.com> * Fix lint and tests Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 2f8c6f4) Co-authored-by: Derek Ho <dxho@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adopts to nav changes in core when a feature flag is enabled
Category
Enhancement
Why these changes are required?
Fix: #2020
What is the old behavior before changes and new behavior after changes?
Screen.Recording.2024-07-18.at.4.44.10.PM.mov
The first part of the video is the current behavior and the behavior with the feature flag off, the second part of the video is the new behavior with the feature flag on.
Issues Resolved
Fix: #2020
Testing
Manual testing. Since the feature branch is not yet merged in core and many of the API calls are simply registration calls from exposed APIs code tests don't seem feasible.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.