Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.8] Fixing dynamic tenancy changes for issues 1412 #1457

Merged

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented May 31, 2023

Backport of #1419 to 2.8

* Fixing dynamic tenancy changes for opensearchdasbhoard.yaml

Signed-off-by: Abhi Kalra <abhivka@amazon.com>
Co-authored-by: Abhi Kalra <abhivka@amazon.com>
Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
(cherry picked from commit c4e6c37)
@RyanL1997
Copy link
Collaborator

FYI: The prerequisite check will not block the merging.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #1457 (dc2d304) into 2.8 (920e6eb) will decrease coverage by 0.05%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##              2.8    #1457      +/-   ##
==========================================
- Coverage   65.51%   65.47%   -0.05%     
==========================================
  Files          93       93              
  Lines        2294     2297       +3     
  Branches      307      313       +6     
==========================================
+ Hits         1503     1504       +1     
- Misses        723      725       +2     
  Partials       68       68              
Impacted Files Coverage Δ
...s/configuration/panels/tenant-list/tenant-list.tsx 3.44% <50.00%> (+3.44%) ⬆️
public/plugin.ts 12.69% <50.00%> (-0.21%) ⬇️
public/apps/account/account-nav-button.tsx 63.88% <100.00%> (ø)
...ps/configuration/panels/tenant-list/manage_tab.tsx 69.12% <100.00%> (ø)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Copy link
Member Author

cwperks commented May 31, 2023

@DarshitChanpura @RyanL1997 I had to push a change to update the versions referenced in the new workflow. Since the workflow is testing the code introduced in this PR we should verify those checks before merging.

@peterzhuamazon
Copy link
Member

peterzhuamazon commented May 31, 2023

Per @cwperks and @RyanL1997 this is a flaky test (12th run pass on this specific PR), which will be addressed in the next minor version.

Merge now.

Thanks.

@RyanL1997
Copy link
Collaborator

Thanks @peterzhuamazon for the help on merging. Yes, this is a known flaky, and this fix has already planned to remove it for 2.8 branch

@peterzhuamazon
Copy link
Member

Thanks @peterzhuamazon for the help on merging. Yes, this is a known flaky, and this fix has already planned to remove it for 2.8 branch

Great thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants