Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing OIDC refresh token calls in case of expired id token #2015

Closed
uladzimir-tryputska opened this issue Jun 21, 2024 · 1 comment
Closed
Labels
bug Something isn't working untriaged

Comments

@uladzimir-tryputska
Copy link

What is the bug?
Dashboard security plugin doesn't call refresh token in case id token is expired

How can one reproduce the bug?
Steps to reproduce the behavior:
We are using Gitlab as IDP, where id token life time is 2 minutes. Or any IDP can be used with small token expiration time

  • Login into Opensearch Dashboard
  • Wait for > 2 mins
  • Click any link on the Dashboard-> relogin happens

What is the expected behavior?
Refresh token end point call happens and new id token is used for further request

What is your host/environment?
Opensearch Dashboard image 2.14.0.0

Do you have any additional context?
isValidCookie() https://github.com/opensearch-project/security-dashboards-plugin/blob/2.14.0.0/server/auth/types/authentication_type.ts#L145, where refresh token logic is located, is not called any more, because cookie is cleared here https://github.com/opensearch-project/security-dashboards-plugin/blob/2.14.0.0/server/auth/types/authentication_type.ts#L139. And it is cleared because token is expired. Expiration logic was changed recently.

@derek-ho
Copy link
Collaborator

This was merged in time for 2.15 release, it should fix it: #1990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged
Projects
None yet
Development

No branches or pull requests

3 participants