Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Run CI checks after building OSD, security-dashboards-plugin zip and installing with the ./bin/opensearch-dashboards-plugin install file:/path/to/security-dashboards-plugin.zip #1709

Closed
cwperks opened this issue Dec 26, 2023 · 2 comments · Fixed by #1726
Assignees
Labels
bug Something isn't working flaky-test triaged

Comments

@cwperks
Copy link
Member

cwperks commented Dec 26, 2023

What is the bug?

When security-dashboards-plugin runs OpenSearch-Dashboards w/ the security dashboards plugin installed, it starts OSD using yarn start instead of a built version of OSD and using the executable script ./bin/opensearch-dashboards.

There's been a couple of issues that have slipped by the CI checks that would be caught with this.

The CI checks should be refactored to build OSD, security-dashboards-plugin and install the dashboards plugin using the dashboards-plugin install executable.

  1. In OSD-Core run yarn build. Output is in ./build/opensearch-dashboards-{version}-{platform}-{architecture}/
  2. In security-dashboards-plugin run yarn build. Output is in ./build/security-dashboards-{version}.zip
  3. Install the dashboards plugin. In ./build/opensearch-dashboards-{version}-{platform}-{architecture}/ run ./bin/opensearch-dashboards-plugin install file:/path/to/security-dashboards-plugin.zip
  4. Run OSD with ./bin/opensearch-dashboards
@stephen-crawford
Copy link
Contributor

[Triage] Hi @cwperks, thanks for filing this issue. This is a great issue since it will help us have more affective testing.

@derek-ho
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flaky-test triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants