Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Need for invalid permission clean up? #1483

Closed
peternied opened this issue Jun 22, 2023 · 3 comments
Closed

[BUG] Need for invalid permission clean up? #1483

peternied opened this issue Jun 22, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@peternied
Copy link
Member

What is the bug?
Coming from #1481, there is a possiblity that users have used the Dashboards dropdown to create permissions object were a cluster permission was included in the list of index permissions. These permissions might be creating confusion since they are not authorizing actions as expected.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Edit permission on a role
  2. Select the index permissions
  3. Select the permission indices:data/write/reindex and apply it
  4. Attempt to run a reindex with an account that uses that role

What is the expected behavior?
Reindex should fail because permission really weren't granted, it should be clear how the permissions should be modified to grant that permission

@peternied peternied added bug Something isn't working untriaged labels Jun 22, 2023
@peternied
Copy link
Member Author

@setiah Could you weigh in if you think this requires are migration to detect these invalid configurations and the appropriate action to take on them (Delete the invalid permission, create the correct permission on the role)?

@DarshitChanpura
Copy link
Member

[Triage] @setiah Would you please add you thoughts here?

@peternied
Copy link
Member Author

[Triage] I don't think its clear that this would be high value for security plugin users - this area will be approached when permissions declarations are revisited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants