Ensure that user attributes are in expected format attrKey=attrVal for testing (#1583)

* Ensure that user attributes are in expected format attrKey=attrVal for testing

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Fix testDetector

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>

Author: cwperks

src/test/java/org/opensearch/securityanalytics/TestHelpers.java

@@ -2975,7 +2975,7 @@ public static SATIFSourceConfig randomSATIFSourceConfig(
                 feedFormat,
                 sourceConfigType,
                 description,
-                new User("wrgrer", List.of("b1"), List.of("r1"), List.of("ca")),
+                new User("wrgrer", List.of("b1"), List.of("r1"), List.of("attrKey=ca")),
                 createdAt,
                 source,
                 enabledTime,

src/test/java/org/opensearch/securityanalytics/model/WriteableTests.java

@@ -35,7 +35,7 @@ public void testDetectorAsAStream() throws IOException {
     public void testDetector() throws IOException { // an edge case of detector serialization that failed testDetectorAsAStream() intermittently
         String detectorString = "{\"type\":\"detector\",\"name\":\"MczAuRCrve\",\"detector_type\":\"test_windows\"," +
                 "\"user\":{\"name\":\"QhKrfthgxw\",\"backend_roles\":[\"uYvGLCPhfX\",\"fOLkcRxMWR\"],\"roles\"" +
-                ":[\"YuucNpVzTm\",\"all_access\"],\"custom_attributes\":{\"test_attr\":\"test\"}," +
+                ":[\"YuucNpVzTm\",\"all_access\"],\"custom_attribute_names\":[\"test_attr=test\"]," +
                 "\"user_requested_tenant\":null},\"threat_intel_enabled\":false,\"enabled\":false,\"enabled_time\"" +
                 ":null,\"schedule\":{\"period\":{\"interval\":5,\"unit\":\"MINUTES\"}},\"inputs\":[{\"detector_input\"" +
                 ":{\"description\":\"\",\"indices\":[],\"custom_rules\":[],\"pre_packaged_rules\":[]}}],\"triggers\"" +

src/test/java/org/opensearch/securityanalytics/model/threatintel/ThreatIntelAlertTests.java

@@ -89,7 +89,7 @@ private static ThreatIntelAlert getRandomAlert() {
                 randomAlphaOfLength(10),
                 randomLong(),
                 randomLong(),
-                new User(randomAlphaOfLength(10), List.of(randomAlphaOfLength(10)), List.of(randomAlphaOfLength(10)), List.of(randomAlphaOfLength(10))),
+                new User(randomAlphaOfLength(10), List.of(randomAlphaOfLength(10)), List.of(randomAlphaOfLength(10)), List.of("attrKey=attrVal")),
                 randomAlphaOfLength(10),
                 randomAlphaOfLength(10),
                 randomAlphaOfLength(10),