Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] URL parameters are dropped when redirected back to OS after OAuth authentication #887

Open
filip-piotrowski opened this issue Oct 10, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@filip-piotrowski
Copy link

What is the bug?
If you have no session in OpenSearch and OpenSearch is protected by external IdP via OAuth 2.0, when you launch a "deep link" to e.g. dashboard with some filters etc., after successful authentication you are redirected to baseUrl/app/dashboards instead of the link where you started.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Setup OpenSearch with IdP via OAuth 2.0
  2. Log in to OpenSearch to obtain a "deep link", e.g. link to any dashboard, set time filter to anything else than 15 min to create additional parameter in the URL
  3. Copy the dashboard link
  4. Clear session cookies to force authentication on next interaction with OpenSearch
  5. Launch the link copied in step 3
  6. Complete authentication flow
  7. Notice that you land on /app/dashboards context instead of the specific dashboard along with selections from step 2

What is the expected behavior?
After successfully authenticated user should be brought back to the context with parameters that were orignally requested prior the authentication workflow, instead of the generic landing page.

What is your host/environment?

  • OS:
    Dashboards OS:
    Amazon Linux release 2 (Karoo) (Dashboards default docker container from dockerhub)
    Browser OS:
    Chrome / Windows 10
  • Version 2.7.0
  • Plugins:
    security plugin

Do you have any additional context?
This functionality works fine in a mirror environment based on Elasticsearch 7.10.2, however it is not using OAuth 2.0, it only has basic authentication

@filip-piotrowski filip-piotrowski added bug Something isn't working untriaged labels Oct 10, 2023
@derek-ho
Copy link
Collaborator

@opensearch-project/triage can you move this to Security dashboards repo? This seems more relevant to them

@filip-piotrowski
Copy link
Author

@derek-ho I see there was no action taken, should I create this issue in opensearch-project/security-dashboards-plugin? It seems I can't just move the issue there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants