diff --git a/dashboards-reports/.cypress/integration/01-create.spec.ts b/dashboards-reports/.cypress/integration/01-create.spec.ts index 10a706b7..cdeee520 100644 --- a/dashboards-reports/.cypress/integration/01-create.spec.ts +++ b/dashboards-reports/.cypress/integration/01-create.spec.ts @@ -83,6 +83,9 @@ describe('Cypress', () => { // set report trigger to Schedule option cy.get('[type="radio"]').check({ force: true }); + // set source back to saved search for testing purpose + cy.get('#savedSearchReportSource').check({ force: true }); + // create scheduled report definition cy.get('#createNewReportDefinition').click({ force: true }); }); diff --git a/dashboards-reports/public/components/report_definitions/report_settings/report_settings.tsx b/dashboards-reports/public/components/report_definitions/report_settings/report_settings.tsx index e5e1d100..9521af62 100644 --- a/dashboards-reports/public/components/report_definitions/report_settings/report_settings.tsx +++ b/dashboards-reports/public/components/report_definitions/report_settings/report_settings.tsx @@ -163,7 +163,7 @@ export function ReportSettings(props: ReportSettingProps) { reportDefinitionRequest.report_params.report_source = 'Dashboard'; reportDefinitionRequest.report_params.core_params.base_url = getDashboardBaseUrlCreate(edit, editDefinitionId, fromInContext) + - dashboards[0].value; + dashboards[0]?.value; // set params to visual report params after switch from saved search handleDataToVisualReportSourceChange(reportDefinitionRequest); @@ -172,7 +172,7 @@ export function ReportSettings(props: ReportSettingProps) { reportDefinitionRequest.report_params.report_source = 'Visualization'; reportDefinitionRequest.report_params.core_params.base_url = getVisualizationBaseUrlCreate(edit, editDefinitionId, fromInContext) + - visualizations[0].value; + visualizations[0]?.value; // set params to visual report params after switch from saved search handleDataToVisualReportSourceChange(reportDefinitionRequest); @@ -181,9 +181,9 @@ export function ReportSettings(props: ReportSettingProps) { reportDefinitionRequest.report_params.report_source = 'Saved search'; reportDefinitionRequest.report_params.core_params.base_url = getSavedSearchBaseUrlCreate(edit, editDefinitionId, fromInContext) + - savedSearches[0].value; + savedSearches[0]?.value; reportDefinitionRequest.report_params.core_params.saved_search_id = - savedSearches[0].value; + savedSearches[0]?.value; reportDefinitionRequest.report_params.core_params.report_format = 'csv'; reportDefinitionRequest.report_params.core_params.limit = 10000; reportDefinitionRequest.report_params.core_params.excel = true; @@ -191,7 +191,7 @@ export function ReportSettings(props: ReportSettingProps) { reportDefinitionRequest.report_params.report_source = 'Notebook'; reportDefinitionRequest.report_params.core_params.base_url = getNotebooksBaseUrlCreate(edit, editDefinitionId, fromInContext) + - notebooks[0].value; + notebooks[0]?.value; // set params to visual report params after switch from saved search handleDataToVisualReportSourceChange(reportDefinitionRequest);