Added shard operations collector and optimized node stats collector #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nishchay21 <nishcha@amazon.com>
Signed-off-by: nishchay21 <nishcha@amazon.com>
nishchay21
requested review from
Gaganjuneja,
Shephalimittal,
ansjcy,
khushbr,
psychbot,
rramachand21 and
sbcd90
as code owners
Signed-off-by: nishchay21 <nishcha@amazon.com>
Gaganjuneja
requested changes
Jul 1, 2025
| for (Map.Entry<ShardId, ShardStats> currentShard : currentPerShardStats.entrySet()) { | ||
| ShardId shardId = currentShard.getKey(); | ||
| ShardStats currentShardStats = currentShard.getValue(); | ||
| if (prevPerShardStats.isEmpty() || !prevPerShardStats.containsKey(shardId)) { |
There was a problem hiding this comment.
Can we check !null here itself?
| // attributes= {index_name="test", shard_id="0"} | ||
| private Tags createTags(ShardId shardId) { | ||
| return Tags.create() | ||
| .addTag(RTFMetrics.CommonDimension.INDEX_NAME.toString(), shardId.getIndexName()) |
There was a problem hiding this comment.
Add index uuid as well?
| * @param indexOps count of index operations. | ||
| * @param searchOps count of search operations | ||
| */ | ||
| public record ShardOperation(long indexOps, long searchOps) {} |
There was a problem hiding this comment.
Do we need this as public?
Signed-off-by: nishchay21 <nishcha@amazon.com>
Gaganjuneja
previously approved these changes
Jul 2, 2025
Signed-off-by: nishchay21 <nishcha@amazon.com>
Signed-off-by: nishchay21 <nishcha@amazon.com>
Signed-off-by: Nishchay Malhotra <114057571+nishchay21@users.noreply.github.com>
Signed-off-by: nishchay21 <nishcha@amazon.com>
nishchay21
force-pushed
the
nishcha-dev
branch
from
7799cec to
21f3f7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added shard operations collector and optimized node stats collector
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.