Eliminate screenreader content when copying and pasting data grid table #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbyhu2000
requested review from
AMoo-Miki,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
ashwin-pc
approved these changes
Jan 8, 2024
BSFishy
reviewed
Jan 10, 2024
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
abbyhu2000
force-pushed
the
data_grid_copy
branch
from
388075b
to
ca9e2c5
Compare
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
ashwin-pc
approved these changes
Jan 18, 2024
AMoo-Miki
approved these changes
Jan 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
…le (#1198) * Eliminate screenreader content when copy paste of data grid table Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add changelog Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add it to current theme Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit 386da22) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
BSFishy
pushed a commit
that referenced
this pull request
Jan 25, 2024
…le (#1198) (#1220) * Eliminate screenreader content when copy paste of data grid table Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add changelog Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add it to current theme Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit 386da22) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Eliminate the extra "Row # Column #" when selecting data grid table and pasting.
Issues Resolved
resolves opensearch-project/OpenSearch-Dashboards#5570
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.