Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "Widths" section from the OuiModal docs #803

Closed
joshuarrrr opened this issue Jun 9, 2023 · 4 comments
Closed

Remove the "Widths" section from the OuiModal docs #803

joshuarrrr opened this issue Jun 9, 2023 · 4 comments
Assignees
Labels
good first issue Good for newcomers OUIDocs

Comments

@joshuarrrr
Copy link
Member

In https://oui.opensearch.org/1.0/#/layout/modal, we have a section about how to manually specify widths via inline styles. This seems like a bit of an antipattern, and not something we want to encourage. See #783 for examples where we do customize modal widths today.

If we do want to allow direct sizing controls, we probably want to add more props. Otherwise, I think we should just scratch the section altogether.
Screen Shot 2023-06-08 at 5 38 03 PM

@KrooshalUX
Copy link
Contributor

I agree that we should remove this guidance - it does not align with the Design System directive to rely on the responsive system as much as possible out of the box.

@BSFishy BSFishy changed the title Should we remove the "Widths" section from the OuiModal docs? Remove the "Widths" section from the OuiModal docs Jun 20, 2023
@BSFishy BSFishy added the good first issue Good for newcomers label Jun 20, 2023
@BigSamu
Copy link
Contributor

BigSamu commented Oct 4, 2023

@joshuarrrr @BSFishy can I take this issue?

@BSFishy BSFishy assigned BigSamu and unassigned KrooshalUX Oct 4, 2023
@BSFishy
Copy link
Contributor

BSFishy commented Oct 4, 2023

Yep, looks like this is ready to pick up

@BigSamu BigSamu mentioned this issue Oct 6, 2023
7 tasks
@BSFishy
Copy link
Contributor

BSFishy commented Oct 13, 2023

Fixed in #1066

@BSFishy BSFishy closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers OUIDocs
Projects
Status: Done
Development

No branches or pull requests

4 participants