Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(OUI Icons) Visualize for SQl / PPL / PromQL #637

Open
anirudha opened this issue Mar 27, 2023 · 6 comments
Open

(OUI Icons) Visualize for SQl / PPL / PromQL #637

anirudha opened this issue Mar 27, 2023 · 6 comments
Assignees
Labels

Comments

@anirudha
Copy link

Is your feature request related to a problem? Please describe.
We need new feature icons for :
Query PPL - create a visualization with Piped processigng language
Query PromQL - create a visualization with Prometheus Query Language
Query SQL - create a visualization with SQL

Describe the solution you'd like
A simple icon that says, SQL , PPL , PromQL

@anirudha anirudha added the enhancement New feature or request label Mar 27, 2023
@KrooshalUX KrooshalUX changed the title New Icons on Visualize for SQl / PPL / PromQL (OUI Icons) Visualize for SQl / PPL / PromQL Mar 27, 2023
@KrooshalUX
Copy link
Contributor

@anirudha a few follow up thoughts and questions in order to ensure we create the appropriate visual representation.

  • Can a user create multiple visualizations from any of the query languages above? IE: Line, area, pie, etc
  • These visualizations are now Saved Objects, correct? If so, we need to also consider if we use the same icon for "visualization" in that saved objects list, or if we differentiate the icon like we did for VisBuilder, because the "shape" of the object is different, which may matter to admins. @ashwin-pc can you weigh in on this?
  • Are these visualization types of visualization building methods, like VisBuilder? I believe all thee icons would take the user to the same interface, correct? I am wondering if 3 icons are necessary, since they land the user in the same interface, or if 1 will do the trick? Its a similar model to VisBuilder, where the user choose VisBuilder as the build method and then can create visualizations and change the details as they go.
  • If we do move forward with 3 icons, I would not position them alphabetically in this list, either, but target adding them next to VisBuilder as they are build types. Would that be possible?

Additionally - we could target 2.8 to redesign the New visualization modal in order to address the new paradigm of different ways to build visualizations. I have created a related issue here to address the mis-match of what we are trying to communicate in this modal.

Screen Shot 2023-03-27 at 12 11 12 PM

@anirudha
Copy link
Author

We are releasing this is 2.7 as per the core and observability cohesion.

  • you can create line, bar, pie etc all ppl based viz. more will be added in 2.8
  • this is core vis object and will support the type visualization as a type
  • the current list is alphabetical, we need to change that or create a separator for other visualizations let's decide what we want / anything is possible

@KrooshalUX
Copy link
Contributor

Here are the proposed icons - one for PromQL, SQL, PPL and a non labeled one to use as the icon for the object in the Saved Objects table.

Screen Shot 2023-03-31 at 6 42 48 PM

Note: these were delivered to OUI today in order to cut the OUI 1.1 release in order to give you the correct icon name space. I call this out because we need more time to iterate on the label fidelity, but given the short timeline this was the best we could do.

Please refer to this issue #628 for the names of the icons as they will be listed in OUI.

@canascar
Copy link
Member

canascar commented Apr 1, 2023

Fixed issue regarding discrepancy with "PPL" in icon, please review.
Screen Shot 2023-04-01 at 7 55 53 AM

@KrooshalUX
Copy link
Contributor

Closing as complete design task request - see issue #628 for adding these icons to OUI in prep for 1.1 release.

@anirudha
Copy link
Author

can we have a simpler icon for PPL that will be clearly visible in tiny settings eg. or just PPL
cc: nitin josh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

3 participants