Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(OUI Docs) Remove logos from Page title on /layout/page #625

Open
1 task
KrooshalUX opened this issue Mar 23, 2023 · 3 comments · Fixed by #639
Open
1 task

(OUI Docs) Remove logos from Page title on /layout/page #625

KrooshalUX opened this issue Mar 23, 2023 · 3 comments · Fixed by #639
Assignees
@BSFishy
Labels
OUIDocs technical debt

Comments

@KrooshalUX
Copy link
Contributor

KrooshalUX commented Mar 23, 2023 •
edited
Loading

  • Remove all logos from Page title sections in all examples (7 in total). Previously, I believe there may have been a bug which hid the logo placed originally by elastic. Regardless, we do not use logos or icons in our page titles so the logos in the examples should be removed.

Screen Shot 2023-03-23 at 10 25 25 AM
@KrooshalUX KrooshalUX mentioned this issue Mar 23, 2023
Open
2 tasks
@AbhishekReddy1127 AbhishekReddy1127 self-assigned this Mar 23, 2023
@AbhishekReddy1127 AbhishekReddy1127 mentioned this issue Mar 28, 2023
Merged
6 tasks
@joshuarrrr
Copy link
Member

@KrooshalUX Do we want a follow-up issue to actually remove/deprecate the <OuiPageHeader> iconType prop?

@KrooshalUX KrooshalUX mentioned this issue Mar 29, 2023
Closed
@KrooshalUX KrooshalUX mentioned this issue Apr 10, 2023
Open
1 task
@KrooshalUX
Copy link
Contributor Author

This PR is merged and closed, however I see an elastic logo on the page in 1.0 and 1.1 versions:
Screen Shot 2023-05-02 at 12 39 46 PM

Screen Shot 2023-05-02 at 12 39 31 PM

@KrooshalUX KrooshalUX reopened this May 2, 2023
@KrooshalUX KrooshalUX mentioned this issue May 2, 2023
Closed
@kavilla kavilla removed the untriaged label May 9, 2023
@kavilla kavilla assigned BSFishy and unassigned AbhishekReddy1127 May 9, 2023
@SergeyMyssak
Copy link
Collaborator

The necessary PR (#639) was not backported to 1.x (#851) so in 1.2 the changes have not been applied. @joshuarrrr, I see that we do not have backport 1.2 tag. To create it, do I need to take special steps to do so?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BSFishy BSFishy

Labels
OUIDocs technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove logos for page examples AbhishekReddy1127/oui
7 participants
@joshuarrrr @BSFishy @kavilla @SergeyMyssak @ashwin-pc @AbhishekReddy1127 @KrooshalUX