-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Fix console warnings about 'Query' export #1063
Comments
This appears to be an issue with (maybe?) Typescript and exporting the I've been investigating this for a little bit and can't find anything on my end. What Babel outputs (which runs after Typescript) has correct exports, so this is maybe just a bug in Webpack. This will probably be a matter of changing lines that say import { Query } from './query'; into import { Query } from './query/query'; Most likely will need this change in
You can see how those files are change in #770 for these changes |
Is it okay to also address the issue with the 'Ast' import as a part of this bug fix, or should I just focus on the 'Query' import? |
Yeah definitely. No need in creating multiple PR/issues if they are related :) |
Yeah, most likely you'll need to make a separate export in export { Query } from './query/query';
export { AST as Ast } from './query/ast'; |
@JohnathonBowers Go ahead with that fix to de-alias |
Sounds good, @joshuarrrr . Is it okay to open up a separate issue for this, or would you prefer that I keep the fix in the same PR as the Query path fix? |
separate PR/issue is always welcome |
@joshuarrrr yes. Something similar came up when upgrading webpack: #770 (comment) |
I said this in Slack, but my theory is something along the lines that Webpack has some sort of bug on Mac in v4 and always in v5 that causes this. Potentially some sort of platform-specific optimization in v4, since this only popped up when people started using Mac's to develop. I checked the Babel output for both CJS and ESM for these files, and they seem just fine, even work without any problems with Node. In my mind, that only leaves Webpack as the culprit of this issue. Potentially Webpack trying to perform some sort of transpilation for an older target?? |
@BSFishy @joshuarrrr I just opened a new issue for the |
Describe the bug
When I try to run the OUI documentation site, I see a number of warnings in my console regarding a missing export 'Query'.
To Reproduce
Steps to reproduce the behavior:
yarn install
and thenyarn start
Expected behavior
These warnings should not appear. :)
Screenshots
Host/Environment (please complete the following information):
Additional context
N/A
The text was updated successfully, but these errors were encountered: