Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bash in systemd-entrypoint shebang #4008

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Use bash in systemd-entrypoint shebang #4008

merged 1 commit into from
Jul 26, 2022

Conversation

shdubsh
Copy link
Contributor

@shdubsh shdubsh commented Jul 25, 2022

Description

Uses a shell environment where -o pipefail is available.

Issues Resolved

Closes #4005

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@shdubsh
Use bash in systemd-entrypoint shebang
ecd6cd9 
Uses a shell environment where `-o pipefail` is available.

Closes #4005

Signed-off-by: Cole White <cwhite@wikimedia.org>
@shdubsh shdubsh requested review from a team and reta as code owners July 25, 2022 21:11
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross andrross merged commit b24b02f into opensearch-project:main Jul 26, 2022
@andrross andrross added the backport 2.x Backport to 2.x branch label Jul 26, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 26, 2022
@shdubsh @github-actions
Use bash in systemd-entrypoint shebang (#4008)
1f5993e 
Uses a shell environment where `-o pipefail` is available.

Closes #4005

Signed-off-by: Cole White <cwhite@wikimedia.org>
(cherry picked from commit b24b02f)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 26, 2022
Merged
dblock pushed a commit that referenced this pull request Jul 27, 2022
@opensearch-trigger-bot @shdubsh
Use bash in systemd-entrypoint shebang (#4008) (#4009)
d44414e 
Uses a shell environment where `-o pipefail` is available.

Closes #4005

Signed-off-by: Cole White <cwhite@wikimedia.org>
(cherry picked from commit b24b02f)

Co-authored-by: Cole White <42356806+shdubsh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrross andrross andrross approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] /usr/share/opensearch/bin/systemd-entrypoint: 6: set: Illegal option -o pipefail
2 participants
@shdubsh @andrross