Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCI][FEATURE] Should tests be run during ci/cd? #124

Closed
bl1nkker opened this issue Mar 27, 2023 · 2 comments
Closed

[CCI][FEATURE] Should tests be run during ci/cd? #124

bl1nkker opened this issue Mar 27, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@bl1nkker
Copy link
Contributor

Is your feature request related to a problem?
At the moment I'm working on codecov integration issue. Having looked into the ci.yml, I saw that tests are not being carried out on Linux. In my opinion, this is a big problem, given that in opensearch-py repository, tests are run during ci / cd

What solution would you like?
Running tests during CI/CD

Do you have any additional context?
Additionally, I want to clarify something. In opensearch-py, Jenkins/Github actions only run server tests. And there is no clear separation of tests in this repository. Should tests be run at all?

@bl1nkker bl1nkker added enhancement New feature or request untriaged labels Mar 27, 2023
@bl1nkker bl1nkker changed the title [CCI][FEATURE] [CCI][FEATURE] Should tests be added before ci/cd? Mar 27, 2023
@bl1nkker bl1nkker changed the title [CCI][FEATURE] Should tests be added before ci/cd? [CCI][FEATURE] Should tests be run during ci/cd? Mar 27, 2023
@dhrubo-os
Copy link
Collaborator

Most of our tests are mostly integration test as we need to pull data from opensearch or upload model to opensearch. So writing only unit test doesn't make enough sense for most of the cases.

Why do you think tests are not carried out on linux is a problem?

Tests are being run in Docker. One thing we can do is after running the tests in docker and generating the xml file of the code coverage in docker we can copy that file to the linux like this

Please let me know what do you think?

@bl1nkker
Copy link
Contributor Author

bl1nkker commented Apr 7, 2023

Yeah, got it!

@bl1nkker bl1nkker closed this as completed Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants