Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] deprecation warnings are missing from .d.ts files #637

Closed
alex-at-cascade opened this issue Oct 25, 2023 · 1 comment · Fixed by #645
Closed

[BUG] deprecation warnings are missing from .d.ts files #637

alex-at-cascade opened this issue Oct 25, 2023 · 1 comment · Fixed by #645
Labels
good first issue Good for newcomers

Comments

@alex-at-cascade
Copy link
Contributor

What is the bug?

In index.d.ts, there is no deprecation warning on putTemplate, even though the javascript source does have one. Based on the lack of warning, I used this function, resulting in an unfortunate outcome.

How can one reproduce the bug?

In an IDE, autocomplete from client.indices. and see putTemplate come up.

What is the expected behavior?

Deprecation warnings would be carried to the .d.ts declarations. (Would be even better if all the jsdoc was carried over.)

What is your host/environment?

N/A

Do you have any screenshots?

N/A

Do you have any additional context?

N/A

@nhtruong
Copy link
Collaborator

Thanks for bringing it up #645 will take care of this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants