Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] ModelTestCase.mapper improvements #770

Open
channel-dante opened this issue Dec 18, 2023 · 4 comments
Open

[PROPOSAL] ModelTestCase.mapper improvements #770

channel-dante opened this issue Dec 18, 2023 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@channel-dante
Copy link
Contributor

What/Why

What are you proposing?

  • Modify the ModelTestCase model's mapper to use only one fixedly or both to use both fixedly.
image

What problems are you trying to solve?

  • I don't think it's good code if a test passes or breaks randomly. It seems like a good idea to organize the reasons for using two mappers and improve it so that they are always used when both are needed.

What is the developer experience going to be?

  • No more cases of partially passing or failing tests
@dblock
Copy link
Member

dblock commented Dec 18, 2023

100% thanks!

@dblock dblock added bug Something isn't working good first issue Good for newcomers and removed untriaged labels Dec 18, 2023
@channel-dante
Copy link
Contributor Author

channel-dante commented Dec 19, 2023

@dblock Do you think that both mapper should support here? I think I can work on it once the decision is made.

@Jai2305
Copy link
Contributor

Jai2305 commented Jul 7, 2024

Hi @channel-dante and @dblock , we are adding a default Mapper in JsonUtils in this PR , please follow this comment to know the context, I think we can use that , rather than hardcoding one of them, the idea is to take the provider from the classpath instead of hardcoding one of the jakarta or Jackson

Caution : the methods in the mapper are overridden to provide support for the classes which implement JsonpSerializable

@dblock
Copy link
Member

dblock commented Jul 8, 2024

I am not sure what the implications of either are, let's look at the code! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants