Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Release 3.0 #264

Closed
dblock opened this issue Mar 23, 2023 · 16 comments · Fixed by #448
Closed

[FEATURE] Release 3.0 #264

dblock opened this issue Mar 23, 2023 · 16 comments · Fixed by #448
Labels
enhancement New feature or request untriaged

Comments

@dblock
Copy link
Member

dblock commented Mar 23, 2023

Is your feature request related to a problem?

We have some awesome (and breaking) changes in 3.0 that help developers write better code, e.g. #246 (comment).

What solution would you like?

Release 3.0!

@dblock dblock added enhancement New feature or request untriaged labels Mar 23, 2023
@wbeckler wbeckler removed the untriaged label Apr 3, 2023
@wbeckler
Copy link

wbeckler commented Apr 7, 2023

There's a possible issue coming down the pipe that might be breaking. It would be nice to pile all the breaking stuff into one release so we don't need to go to 4.0.

@Jakob3xD
Copy link
Collaborator

@dblock Imo we could do a release once the two open PRs get merged.
I don´t think that we will have the plugins like security and ism ready withing the next few weeks and as they should only extend and not brake anything, I see no point in holding back a release.

@dblock
Copy link
Member Author

dblock commented Nov 20, 2023

💯

@dblock dblock pinned this issue Dec 4, 2023
@dblock
Copy link
Member Author

dblock commented Dec 4, 2023

@Jakob3xD I think we're good to go, are we? Want to make a release?

@Jakob3xD
Copy link
Collaborator

Jakob3xD commented Dec 6, 2023

@Jakob3xD I think we're good to go, are we? Want to make a release?

What is the exact process to do a new release?
Do I make a PR where I bump the version in internal/version/version.go to 3.0.0 and change the CHANGELOG.md from ## [Unreleased] to ## [v3.0.0], then merge it into main? Or don´t we keep a history of CHANGELOG and only list unreleased changes? Afterwards create branches named 3.x and 3.0. So that I create a tag named v3.0.0 out of branch 3.0.

@dblock
Copy link
Member Author

dblock commented Dec 6, 2023

@Xtansia Did you do the last one?

I believe yes, 1) you make changes on main for the version and CHANGELOG, then make a tag and the rest is automated, 2) increment version to 3.0.1 and PR/commit that.

I don't think we need a 3.x or a 3.0 branch, we can continue releasing off main. Those are only needed if we want to continue releasing 2.x versions for example, which I'd rather not.

Will you help us with documenting this as you go in https://github.com/opensearch-project/opensearch-go/blob/main/RELEASING.md, please?

@Xtansia
Copy link
Contributor

Xtansia commented Dec 6, 2023

I didn't do the last release, Vacha did, I don't have maintainer permissions on this client.

The version bump PR from then shows a couple places to change the version: 288e46e

@Jakob3xD
Copy link
Collaborator

I created the Tag and mad a release https://github.com/opensearch-project/opensearch-go/releases/tag/v3.0.0 I hope this is okay? Please edit if something is wrong.

@dblock
Copy link
Member Author

dblock commented Dec 11, 2023

Looking at https://pkg.go.dev/github.com/opensearch-project/opensearch-go/ I don't see a release. I have no idea what the "right way" is, @VachaShah could you help make a release and help us make sure that's automated and documented correctly this time around?

@Jakob3xD
Copy link
Collaborator

I repushed the v3.0.0 tag with the module change to v3. At lease downloading the lib works now.

go get github.com/opensearch-project/opensearch-go/v3

@Jakob3xD
Copy link
Collaborator

@dblock
Copy link
Member Author

dblock commented Dec 11, 2023

Amazing. I upgraded my little demo project in dblock/opensearch-go-client-demo@bad06d1. Do PR any improvements to the code ;)

@dblock dblock closed this as completed Dec 11, 2023
@dblock
Copy link
Member Author

dblock commented Dec 11, 2023

Reopening this since we still need to bump the version to 3.0.1. @Jakob3xD

How does the magic of publishing a release for the go client happen? Is it something we registered once on pkg.go.dev and it just auto-publishes all releases from GitHub? @VachaShah

@dblock dblock reopened this Dec 11, 2023
@VachaShah
Copy link
Collaborator

Apologies for being late on this! I was out on vacation. For golang packages, pushing a tag to the repo makes them available to use. https://go.dev/doc/modules/publishing

@Jakob3xD
Copy link
Collaborator

Reopening this since we still need to bump the version to 3.0.1. @Jakob3xD

Why do we need this? What change is happening with the release?

@dblock
Copy link
Member Author

dblock commented Dec 12, 2023

@Jakob3xD I suggest we bump the version for the next developer iteration, so that we don't have code that still says 3.0 while it already has changes on top of that (it's no longer 3.0). We also need to update CHANGELOG to Unreleased. I did this in #448, take a look?

@dblock dblock unpinned this issue Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants