-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Release 3.0 #264
Comments
There's a possible issue coming down the pipe that might be breaking. It would be nice to pile all the breaking stuff into one release so we don't need to go to 4.0. |
@dblock Imo we could do a release once the two open PRs get merged. |
💯 |
@Jakob3xD I think we're good to go, are we? Want to make a release? |
What is the exact process to do a new release? |
@Xtansia Did you do the last one? I believe yes, 1) you make changes on main for the version and CHANGELOG, then make a tag and the rest is automated, 2) increment version to 3.0.1 and PR/commit that. I don't think we need a 3.x or a 3.0 branch, we can continue releasing off main. Those are only needed if we want to continue releasing 2.x versions for example, which I'd rather not. Will you help us with documenting this as you go in https://github.com/opensearch-project/opensearch-go/blob/main/RELEASING.md, please? |
I didn't do the last release, Vacha did, I don't have maintainer permissions on this client. The version bump PR from then shows a couple places to change the version: 288e46e |
I created the Tag and mad a release https://github.com/opensearch-project/opensearch-go/releases/tag/v3.0.0 I hope this is okay? Please edit if something is wrong. |
Looking at https://pkg.go.dev/github.com/opensearch-project/opensearch-go/ I don't see a release. I have no idea what the "right way" is, @VachaShah could you help make a release and help us make sure that's automated and documented correctly this time around? |
I repushed the v3.0.0 tag with the module change to v3. At lease downloading the lib works now.
|
It is now present https://pkg.go.dev/github.com/opensearch-project/opensearch-go/v3 |
Amazing. I upgraded my little demo project in dblock/opensearch-go-client-demo@bad06d1. Do PR any improvements to the code ;) |
Reopening this since we still need to bump the version to 3.0.1. @Jakob3xD How does the magic of publishing a release for the go client happen? Is it something we registered once on pkg.go.dev and it just auto-publishes all releases from GitHub? @VachaShah |
Apologies for being late on this! I was out on vacation. For golang packages, pushing a tag to the repo makes them available to use. https://go.dev/doc/modules/publishing |
Why do we need this? What change is happening with the release? |
Is your feature request related to a problem?
We have some awesome (and breaking) changes in 3.0 that help developers write better code, e.g. #246 (comment).
What solution would you like?
Release 3.0!
The text was updated successfully, but these errors were encountered: