Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD]Update cypress tests for sigV4 & serverless support #669

Merged
merged 1 commit into from
May 26, 2023

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented May 24, 2023

Description

CI should pass once we merge PR: opensearch-project/OpenSearch-Dashboards#4126

locally passed
image

Issues Resolved

#665

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Su <szhongna@amazon.com>
@CCongWang
Copy link
Collaborator

Hi @zhongnansu , could you please confirm that this PR needs to be backported to 2.x?

@zhongnansu
Copy link
Member Author

Hi @zhongnansu , could you please confirm that this PR needs to be backported to 2.x?

@CCongWang yes, it should be backported to 2.x, and release in 2.8.0.

@zhongnansu
Copy link
Member Author

I don't have permission to label

@kristenTian
Copy link
Contributor

LGTM!

@zhongnansu
Copy link
Member Author

@CCongWang Can you help re-trigger the CI. Since opensearch-project/OpenSearch-Dashboards#4126 is merged, CI should pass

@kavilla kavilla merged commit 9ebded5 into opensearch-project:main May 26, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 26, 2023
Signed-off-by: Su <szhongna@amazon.com>
(cherry picked from commit 9ebded5)
peterzhuamazon pushed a commit that referenced this pull request May 26, 2023
Signed-off-by: Su <szhongna@amazon.com>
(cherry picked from commit 9ebded5)

Co-authored-by: Zhongnan Su <szhongna@amazon.com>
leanneeliatra pushed a commit to leanneeliatra/opensearch-dashboards-functional-test-fork that referenced this pull request Sep 15, 2023
…roject#669) (opensearch-project#686)

Signed-off-by: Su <szhongna@amazon.com>
(cherry picked from commit 9ebded5)

Co-authored-by: Zhongnan Su <szhongna@amazon.com>
Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants