fix lint and introduce a link checker workflow #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tianle Huang <tianleh@amazon.com>
Signed-off-by: Tianle Huang <tianleh@amazon.com>
tianleh
requested review from
CCongWang,
kavilla,
seraphjiang,
ohltyler and
mpabba3003
seraphjiang
approved these changes
Nov 10, 2022
ashwin-pc
approved these changes
Nov 10, 2022
kavilla
approved these changes
Nov 10, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 10, 2022
* fix lint Signed-off-by: Tianle Huang <tianleh@amazon.com> * run lint Signed-off-by: Tianle Huang <tianleh@amazon.com> * add .lycheeexclude Signed-off-by: Tianle Huang <tianleh@amazon.com> * update workflow Signed-off-by: Tianle Huang <tianleh@amazon.com> * fix Signed-off-by: Tianle Huang <tianleh@amazon.com> * test fail Signed-off-by: Tianle Huang <tianleh@amazon.com> * update Signed-off-by: Tianle Huang <tianleh@amazon.com> Signed-off-by: Tianle Huang <tianleh@amazon.com> (cherry picked from commit 20bcdaf)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 10, 2022
* fix lint Signed-off-by: Tianle Huang <tianleh@amazon.com> * run lint Signed-off-by: Tianle Huang <tianleh@amazon.com> * add .lycheeexclude Signed-off-by: Tianle Huang <tianleh@amazon.com> * update workflow Signed-off-by: Tianle Huang <tianleh@amazon.com> * fix Signed-off-by: Tianle Huang <tianleh@amazon.com> * test fail Signed-off-by: Tianle Huang <tianleh@amazon.com> * update Signed-off-by: Tianle Huang <tianleh@amazon.com> Signed-off-by: Tianle Huang <tianleh@amazon.com> (cherry picked from commit 20bcdaf)
tianleh
added a commit
that referenced
this pull request
Nov 10, 2022
* fix lint Signed-off-by: Tianle Huang <tianleh@amazon.com> * run lint Signed-off-by: Tianle Huang <tianleh@amazon.com> * add .lycheeexclude Signed-off-by: Tianle Huang <tianleh@amazon.com> * update workflow Signed-off-by: Tianle Huang <tianleh@amazon.com> * fix Signed-off-by: Tianle Huang <tianleh@amazon.com> * test fail Signed-off-by: Tianle Huang <tianleh@amazon.com> * update Signed-off-by: Tianle Huang <tianleh@amazon.com> Signed-off-by: Tianle Huang <tianleh@amazon.com> (cherry picked from commit 20bcdaf) Co-authored-by: Tianle Huang <60111637+tianleh@users.noreply.github.com>
seraphjiang
pushed a commit
that referenced
this pull request
Nov 10, 2022
* fix lint Signed-off-by: Tianle Huang <tianleh@amazon.com> * run lint Signed-off-by: Tianle Huang <tianleh@amazon.com> * add .lycheeexclude Signed-off-by: Tianle Huang <tianleh@amazon.com> * update workflow Signed-off-by: Tianle Huang <tianleh@amazon.com> * fix Signed-off-by: Tianle Huang <tianleh@amazon.com> * test fail Signed-off-by: Tianle Huang <tianleh@amazon.com> * update Signed-off-by: Tianle Huang <tianleh@amazon.com> Signed-off-by: Tianle Huang <tianleh@amazon.com> (cherry picked from commit 20bcdaf) Co-authored-by: Tianle Huang <60111637+tianleh@users.noreply.github.com>
jakubp-eliatra
pushed a commit
to sebastianmichalski/opensearch-dashboards-functional-test
that referenced
this pull request
Mar 24, 2023
* fix lint Signed-off-by: Tianle Huang <tianleh@amazon.com> * run lint Signed-off-by: Tianle Huang <tianleh@amazon.com> * add .lycheeexclude Signed-off-by: Tianle Huang <tianleh@amazon.com> * update workflow Signed-off-by: Tianle Huang <tianleh@amazon.com> * fix Signed-off-by: Tianle Huang <tianleh@amazon.com> * test fail Signed-off-by: Tianle Huang <tianleh@amazon.com> * update Signed-off-by: Tianle Huang <tianleh@amazon.com> Signed-off-by: Tianle Huang <tianleh@amazon.com> Signed-off-by: Jakub Przybylski <jakub.przybylski@eliatra.com>
leanneeliatra
pushed a commit
to leanneeliatra/opensearch-dashboards-functional-test-fork
that referenced
this pull request
Sep 15, 2023
… (opensearch-project#391) * fix lint Signed-off-by: Tianle Huang <tianleh@amazon.com> * run lint Signed-off-by: Tianle Huang <tianleh@amazon.com> * add .lycheeexclude Signed-off-by: Tianle Huang <tianleh@amazon.com> * update workflow Signed-off-by: Tianle Huang <tianleh@amazon.com> * fix Signed-off-by: Tianle Huang <tianleh@amazon.com> * test fail Signed-off-by: Tianle Huang <tianleh@amazon.com> * update Signed-off-by: Tianle Huang <tianleh@amazon.com> Signed-off-by: Tianle Huang <tianleh@amazon.com> (cherry picked from commit 20bcdaf) Co-authored-by: Tianle Huang <60111637+tianleh@users.noreply.github.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tianle Huang tianleh@amazon.com
Description
Discovered failed commits while working on another task. Will later check how to enforce such.
Test
The workflow can detect when there is lint issue.
https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3432476065/jobs/5721790748
After fixing the link, the workflow is successful. https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3432488571/jobs/5721817064
Issues Resolved
Resolves #360
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.