Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ISM cypress failures due to missing admin certificates #1569

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

DarshitChanpura
Copy link
Member

Adds admin certificates to requests interacting with system index.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@derek-ho
Copy link
Contributor

Let's backport to main and 2.17

"clientCertificates": [
{
"url": "https://localhost:9200/.opendistro-ism*",
"ca": ["cypress/resources/root-ca.pem"],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these entries are needed else the tests would fail to start.

@@ -68,7 +68,7 @@ Cypress.Commands.add('updateManagedIndexConfigStartTime', (index) => {
'POST',
`${Cypress.env('openSearchUrl')}/${
IM_CONFIG_INDEX.OPENDISTRO_ISM_CONFIG
}/_update_by_query`,
}/_update_by_query/`,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing slash is required for cypress to match client-certificates url correctly.

See here for more info.

@cwperks cwperks merged commit c0986d6 into opensearch-project:2.x Sep 11, 2024
39 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 11, 2024
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
(cherry picked from commit c0986d6)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 11, 2024
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
(cherry picked from commit c0986d6)
cwperks pushed a commit that referenced this pull request Sep 11, 2024
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
(cherry picked from commit c0986d6)

Co-authored-by: Darshit Chanpura <dchanp@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Sep 13, 2024
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
(cherry picked from commit c0986d6)

Co-authored-by: Darshit Chanpura <dchanp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants