Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollups/transform: wait for page to render #1091

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

r1walz
Copy link
Contributor

@r1walz r1walz commented Feb 16, 2024

Description

Adding intercepts and wait time to mitigate flaky tests.

Issues Resolved

opensearch-project/index-management-dashboards-plugin#968

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@r1walz
Copy link
Contributor Author

r1walz commented Feb 16, 2024

Please, add labels for v2.12.0, backport 2.xand backport 2.12. Thanks.

cc: @ashwin-pc @ruanyl @tianleh

@r1walz r1walz changed the title ism-dp/transform: wait for page to render rollups/transform: wait for page to render Feb 16, 2024
@r1walz
Copy link
Contributor Author

r1walz commented Feb 16, 2024

Index Management Release tests cypress seems to be stuck. Can someone retrigger the action manually? It's already passing in the ISM-DP PR:

@SuZhou-Joe
Copy link
Member

2.12 has been released, I will remove the backport 2.12 label.

Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
@ashwin-pc ashwin-pc merged commit 4912034 into opensearch-project:main Mar 28, 2024
35 of 36 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1091-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 49120344375af5c2de4e27c5f5cf88f7a0c4b257
# Push it to GitHub
git push --set-upstream origin backport/backport-1091-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1091-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants