[Release 1.3.5] Temp fix bug with build.sh

[prudhvigodithi]

Description

Temporary fix to add an if condition for build.sh to make sure for 1.3.5 publishPluginZipPublicationToZipStagingRepository task is not executed.

Long term:
Should remove this if condition once the 1.3.x reaches EOL or once the branching strategy is in place, this should be resolved

Note: changing the CREATE_GITHUB_ISSUE to false until the issue gets fixed
java.io.FileNotFoundException: /var/jenkins/workspace/distribution-build-opensearch/manifests/1.3.5/opensearch-1.3.5.yml does not

Issues Resolved

#2470

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[prudhvigodithi]

Tes with 1.3.x: ./build.sh manifests/1.3.5/opensearch-1.3.5.yml --component performance-analyzer --snapshot
Result :

BUILD SUCCESSFUL in 56s
16 actionable tasks: 16 executed
++ find . -path '*build/distributions/*.zip'
+ zipPath=./build/distributions/opensearch-performance-analyzer-1.3.5.0-SNAPSHOT.zip
++ dirname ./build/distributions/opensearch-performance-analyzer-1.3.5.0-SNAPSHOT.zip
+ distributions=./build/distributions
+ echo 'COPY ./build/distributions/*.zip'
COPY ./build/distributions/*.zip
+ mkdir -p builds/plugins
+ cp ./build/distributions/opensearch-performance-analyzer-1.3.5.0-SNAPSHOT.zip ./builds/plugins
+ MAVEN_ZIP_PUBLISH_TASK=publishPluginZipPublicationToZipStagingRepository
+ ./gradlew tasks --all
+ grep -qw '^publishPluginZipPublicationToZipStagingRepository'
+ echo 'Not running publishPluginZipPublicationToZipStagingRepository'
Not running publishPluginZipPublicationToZipStagingRepository
2022-08-17 12:33:53 INFO     Recording plugins artifact for performance-analyzer: plugins/opensearch-performance-analyzer-1.3.5.0-SNAPSHOT.zip (from /tmp/tmp7pdhgxro/performance-analyzer/builds/plugins/opensearch-performance-analyzer-1.3.5.0-SNAPSHOT.zip)
2022-08-17 12:33:53 INFO     Checked /tmp/tmp7pdhgxro/performance-analyzer/builds/plugins/opensearch-performance-analyzer-1.3.5.0-SNAPSHOT.zip (1.3.5.0-SNAPSHOT)
2022-08-17 12:33:53 INFO     Created build manifest /usr/share/opensearch/git/pg/opensearch-build/tar/builds/opensearch/manifest.yml
2022-08-17 12:33:53 INFO     Done.

[prudhvigodithi]

Test with 2.2.x: ./build.sh manifests/2.2.0/opensearch-2.2.0.yml --component performance-analyzer --snapshot

Result

BUILD SUCCESSFUL in 1m 2s
27 actionable tasks: 27 executed
+ mkdir -p builds/plugins
+ cp ./build/distributions/opensearch-performance-analyzer-2.2.0.0-SNAPSHOT.zip builds/plugins
+ ./gradlew publishPluginZipPublicationToZipStagingRepository -Dopensearch.version=2.2.0-SNAPSHOT -Dbuild.snapshot=true -Dbuild.version_qualifier=
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.4.1
  OS Info               : Linux 5.4.204-124.362.amzn2int.x86_64 (amd64)
  JDK Version           : 17 (Eclipse Temurin JDK)
  JAVA_HOME             : /opt/java/openjdk-17
  Random Testing Seed   : A5A072C13AC017AB
  In FIPS 140 mode      : false
=======================================

[codecov-commenter]

Codecov Report

Merging #2471 (661ffe6) into main (344648d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2471   +/-   ##
=========================================
  Coverage     94.63%   94.63%           
  Complexity       27       27           
=========================================
  Files           213      213           
  Lines          4324     4324           
  Branches         29       29           
=========================================
  Hits           4092     4092           
  Misses          226      226           
  Partials          6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[dblock]

There are 8 unrelated commits in the history in this PR, please rebase.

[dblock]

I'm very opposed to this fix, because it will hide errors and long term will leave 1.3 branch unbuildable. It's nowhere near EOL. Can we please commit a working build.sh in each component's repo in 1.3 branches instead? That seems like an actual fix, as opposed to a workaround proposed here.

[prudhvigodithi]

I'm very opposed to this fix, because it will hide errors and long term will leave 1.3 branch unbuildable. It's nowhere near EOL. Can we please commit a working build.sh in each component's repo in 1.3 branches instead? That seems like an actual fix, as opposed to a workaround proposed here.

I'm afraid, it could impact the release timeline, as based on the failure per component the script has to be added to the component repo. @dblock
CC @bbarani

[dblock]

I'm very opposed to this fix, because it will hide errors and long term will leave 1.3 branch unbuildable. It's nowhere near EOL. Can we please commit a working build.sh in each component's repo in 1.3 branches instead? That seems like an actual fix, as opposed to a workaround proposed here.

I'm afraid, it could impact the release timeline, as based on the failure per component the script has to be added to the component repo. @dblock CC @bbarani

How so? By how much? How many components are missing a build.sh? These are trivial additions to the repos. Raise PRs.

[prudhvigodithi]

I see for performance-analyzer, performance-analyzer-rca, asynchronous-search, anomaly-detection, index-management, dashboard-reports(reports-scheduler), observability, sql components does have the build.sh and uses the default one.
@dblock

[prudhvigodithi]

I have raised the PR's for each missing component to to add build.sh
opensearch-project/performance-analyzer#252
opensearch-project/asynchronous-search#170
opensearch-project/index-management#470
opensearch-project/performance-analyzer#252
opensearch-project/anomaly-detection#641
opensearch-project/cross-cluster-replication#481
opensearch-project/reporting#426
opensearch-project/observability#945
opensearch-project/sql#766

[dblock]

Thanks @prudhvigodithi! I'll help CR.