Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support both component and incremental arguments in build workflow #4320

Open
zelinh opened this issue Jan 4, 2024 · 2 comments
Open

Support both component and incremental arguments in build workflow #4320

zelinh opened this issue Jan 4, 2024 · 2 comments
Labels
enhancement New Enhancement

Comments

@zelinh
Copy link
Member

zelinh commented Jan 4, 2024

Is your feature request related to a problem? Please describe

Currently we have --component and --incremental as mutually exclusive arguments in our build workflow.

group = parser.add_mutually_exclusive_group()
group.add_argument(
"-c",
"--component",
dest="components",
nargs='*',
type=str,
help="Rebuild one or more components."
)
group.add_argument(
"-i",
"--incremental",
dest="incremental",
default=False,
action="store_true",
help="Given previous build artifacts are present, build incrementally.",
)

Only one argument can be passed into the build workflow at the same time.

Ideally we want both arguments working at the same time in some circumstances.

Describe the solution you'd like

Have both arguments working in the build workflow. If --component <name> --incremental is passed, it should compare the component from the previous build manifest and make a decision to either rebuilt or skip using the diff.

Describe alternatives you've considered

Keep them mutually exclusive.

Additional context

No response

@zelinh zelinh added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Jan 4, 2024
@prudhvigodithi prudhvigodithi removed the untriaged Issues that have not yet been triaged label Jan 16, 2024
@prudhvigodithi
Copy link
Collaborator

[Triage]
@zelinh can we close this issue? as I see the associated PR is merged.
Thanks

@zelinh
Copy link
Member Author

zelinh commented Jan 16, 2024

This issue is actually an enhancement based on the behavior of incremental build implementation.

Currently we don't have a ideal logic for how to handle both component and incremental arguments at the same time, so we make them mutually exclusive.

When user specifies incremental argument, the build workflow will look into the previous build manifest and find out the rebuilding components with commit changes. The component argument will not be used in this case.

I think we may want to explore more on this option to enable both arguments in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants