Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [Plugin CI] OS artifacts not updated immediately in Github runners resulting in blocked plugin CI #3158

Closed
DarshitChanpura opened this issue Jan 29, 2023 · 4 comments
Assignees
Labels
bug Something isn't working untriaged Issues that have not yet been triaged

Comments

@DarshitChanpura
Copy link
Member

Describe the bug
Security Plugin CI failed due to a breaking change introduced in core via opensearch-project/OpenSearch#6009. An PR with the fix was pushed via opensearch-project/security#2418 but the CI failed because the change expected latest artifact to be updated with commit f9eb9bfe17b71aae7e2a00ac0337909f1b3e61e7, but it wasn't.

Here is a task from the failing CI build: https://github.com/opensearch-project/security/actions/runs/4019330649/jobs/6907961463

As a side effect, an auto-cut issue was created because OS distribution build with security plugin failed due to toStrings() signature change not being addressed, even though the fix was available to be merged in time.

Is there a feasible way we can get CI runners updated with latest artifacts as soon as possible to avoid this scenario in future?

Related to opensearch-project/security#2276

Update: As of now CI in unblocked. Seems like the Github runners have updated artifact.

Expected behavior
Github runners should have latest artifacts, so CI is not blocked.

Plugins
Security

@DarshitChanpura DarshitChanpura added bug Something isn't working untriaged Issues that have not yet been triaged labels Jan 29, 2023
@DarshitChanpura DarshitChanpura changed the title [BUG] [Plugin CI] Security plugin CI block due to stale Core OpenSearch artifact [BUG] [Plugin CI] OS artifacts not updated immediately in Github runners resulting in blocked plugin CI Jan 29, 2023
@minalsha minalsha transferred this issue from opensearch-project/OpenSearch Jan 31, 2023
@minalsha
Copy link

@bbarani could you please look into this issue? From OpenSearch Core side, our build is successful but snapshots are stale. Thank you.

@zelinh
Copy link
Member

zelinh commented Jan 31, 2023

It looks like our check-for-build is currently failing because of a syntax error in this PR. #3149
Working on a quick fix.

@bbarani
Copy link
Member

bbarani commented Feb 1, 2023

@DarshitChanpura I am closing this issue as the workflows has started publishing snapshot artifacts for 3.x now. Feel free to re-open if you still have any issues.

@bbarani bbarani closed this as completed Feb 1, 2023
@DarshitChanpura
Copy link
Member Author

Related: #3199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged Issues that have not yet been triaged
Projects
None yet
Development

No branches or pull requests

4 participants